-
Notifications
You must be signed in to change notification settings - Fork 1.3k
/
vmi-create-admitter.go
1662 lines (1502 loc) · 64 KB
/
vmi-create-admitter.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
737
738
739
740
741
742
743
744
745
746
747
748
749
750
751
752
753
754
755
756
757
758
759
760
761
762
763
764
765
766
767
768
769
770
771
772
773
774
775
776
777
778
779
780
781
782
783
784
785
786
787
788
789
790
791
792
793
794
795
796
797
798
799
800
801
802
803
804
805
806
807
808
809
810
811
812
813
814
815
816
817
818
819
820
821
822
823
824
825
826
827
828
829
830
831
832
833
834
835
836
837
838
839
840
841
842
843
844
845
846
847
848
849
850
851
852
853
854
855
856
857
858
859
860
861
862
863
864
865
866
867
868
869
870
871
872
873
874
875
876
877
878
879
880
881
882
883
884
885
886
887
888
889
890
891
892
893
894
895
896
897
898
899
900
901
902
903
904
905
906
907
908
909
910
911
912
913
914
915
916
917
918
919
920
921
922
923
924
925
926
927
928
929
930
931
932
933
934
935
936
937
938
939
940
941
942
943
944
945
946
947
948
949
950
951
952
953
954
955
956
957
958
959
960
961
962
963
964
965
966
967
968
969
970
971
972
973
974
975
976
977
978
979
980
981
982
983
984
985
986
987
988
989
990
991
992
993
994
995
996
997
998
999
1000
/*
* This file is part of the KubeVirt project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* Copyright 2018 Red Hat, Inc.
*
*/
package admitters
import (
"encoding/base64"
"encoding/json"
"fmt"
"net"
"regexp"
"strings"
"k8s.io/api/admission/v1beta1"
k8sv1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/validation"
k8sfield "k8s.io/apimachinery/pkg/util/validation/field"
v1 "kubevirt.io/client-go/api/v1"
"kubevirt.io/kubevirt/pkg/hooks"
"kubevirt.io/kubevirt/pkg/util"
"kubevirt.io/kubevirt/pkg/util/hardware"
webhookutils "kubevirt.io/kubevirt/pkg/util/webhooks"
"kubevirt.io/kubevirt/pkg/virt-api/webhooks"
virtconfig "kubevirt.io/kubevirt/pkg/virt-config"
)
const (
arrayLenMax = 256
maxStrLen = 256
// cloudInitNetworkMaxLen and CloudInitUserMaxLen are being limited
// to 2K to allow scaling of config as edits will cause entire object
// to be distributed to large no of nodes. For larger than 2K, user should
// use NetworkDataSecretRef and UserDataSecretRef
cloudInitUserMaxLen = 2048
cloudInitNetworkMaxLen = 2048
// Copied from kubernetes/pkg/apis/core/validation/validation.go
maxDNSNameservers = 3
maxDNSSearchPaths = 6
maxDNSSearchListChars = 256
)
var validInterfaceModels = map[string]*struct{}{"e1000": nil, "e1000e": nil, "ne2k_pci": nil, "pcnet": nil, "rtl8139": nil, "virtio": nil}
var validIOThreadsPolicies = []v1.IOThreadsPolicy{v1.IOThreadsPolicyShared, v1.IOThreadsPolicyAuto}
var validCPUFeaturePolicies = map[string]*struct{}{"": nil, "force": nil, "require": nil, "optional": nil, "disable": nil, "forbid": nil}
var restriectedVmiLabels = map[string]bool{
v1.CreatedByLabel: true,
v1.MigrationJobLabel: true,
v1.NodeNameLabel: true,
v1.MigrationTargetNodeNameLabel: true,
v1.NodeSchedulable: true,
v1.InstallStrategyLabel: true,
}
type VMICreateAdmitter struct {
ClusterConfig *virtconfig.ClusterConfig
}
func (admitter *VMICreateAdmitter) Admit(ar *v1beta1.AdmissionReview) *v1beta1.AdmissionResponse {
if resp := webhookutils.ValidateSchema(v1.VirtualMachineInstanceGroupVersionKind, ar.Request.Object.Raw); resp != nil {
return resp
}
accountName := ar.Request.UserInfo.Username
vmi, _, err := getAdmissionReviewVMI(ar)
if err != nil {
return webhookutils.ToAdmissionResponseError(err)
}
causes := ValidateVirtualMachineInstanceSpec(k8sfield.NewPath("spec"), &vmi.Spec, admitter.ClusterConfig)
causes = append(causes, ValidateVirtualMachineInstanceMandatoryFields(k8sfield.NewPath("spec"), &vmi.Spec)...)
causes = append(causes, ValidateVirtualMachineInstanceMetadata(k8sfield.NewPath("metadata"), &vmi.ObjectMeta, admitter.ClusterConfig, accountName)...)
// In a future, yet undecided, release either libvirt or QEMU are going to check the hyperv dependencies, so we can get rid of this code.
causes = append(causes, webhooks.ValidateVirtualMachineInstanceHypervFeatureDependencies(k8sfield.NewPath("spec"), &vmi.Spec)...)
if len(causes) > 0 {
return webhookutils.ToAdmissionResponse(causes)
}
reviewResponse := v1beta1.AdmissionResponse{}
reviewResponse.Allowed = true
return &reviewResponse
}
func ValidateVirtualMachineInstanceSpec(field *k8sfield.Path, spec *v1.VirtualMachineInstanceSpec, config *virtconfig.ClusterConfig) []metav1.StatusCause {
var causes []metav1.StatusCause
volumeNameMap := make(map[string]*v1.Volume)
networkNameMap := make(map[string]*v1.Network)
if len(spec.Domain.Devices.Disks) > arrayLenMax {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s list exceeds the %d element limit in length", field.Child("domain", "devices", "disks").String(), arrayLenMax),
Field: field.Child("domain", "devices", "disks").String(),
})
// We won't process anything over the limit
return causes
} else if len(spec.Volumes) > arrayLenMax {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s list exceeds the %d element limit in length", field.Child("volumes").String(), arrayLenMax),
Field: field.Child("volumes").String(),
})
// We won't process anything over the limit
return causes
}
// Validate hostname according to DNS label rules
if spec.Hostname != "" {
errors := validation.IsDNS1123Label(spec.Hostname)
if len(errors) != 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s does not conform to the kubernetes DNS_LABEL rules : %s",
field.Child("hostname").String(), strings.Join(errors, ", ")),
Field: field.Child("hostname").String(),
})
}
}
// Validate subdomain according to DNS subdomain rules
if spec.Subdomain != "" {
errors := validation.IsDNS1123Subdomain(spec.Subdomain)
if len(errors) != 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s does not conform to the kubernetes DNS_SUBDOMAIN rules : %s",
field.Child("subdomain").String(), strings.Join(errors, ", ")),
Field: field.Child("subdomain").String(),
})
}
}
// Validate memory size if values are not negative or too small
if spec.Domain.Resources.Requests.Memory().Value() < 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': must be greater than or equal to 0.", field.Child("domain", "resources", "requests", "memory").String(),
spec.Domain.Resources.Requests.Memory()),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
} else if spec.Domain.Resources.Requests.Memory().Value() > 0 && spec.Domain.Resources.Requests.Memory().Cmp(resource.MustParse("1M")) < 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': must be greater than or equal to 1M.", field.Child("domain", "resources", "requests", "memory").String(),
spec.Domain.Resources.Requests.Memory()),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
}
if spec.Domain.Resources.Limits.Memory().Value() < 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': must be greater than or equal to 0.", field.Child("domain", "resources", "limits", "memory").String(),
spec.Domain.Resources.Limits.Memory()),
Field: field.Child("domain", "resources", "limits", "memory").String(),
})
}
if spec.Domain.Resources.Limits.Memory().Value() > 0 &&
spec.Domain.Resources.Requests.Memory().Value() > spec.Domain.Resources.Limits.Memory().Value() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' is greater than %s '%s'", field.Child("domain", "resources", "requests", "memory").String(),
spec.Domain.Resources.Requests.Memory(),
field.Child("domain", "resources", "limits", "memory").String(),
spec.Domain.Resources.Limits.Memory()),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
}
// Validate hugepages
if spec.Domain.Memory != nil && spec.Domain.Memory.Hugepages != nil {
hugepagesSize, err := resource.ParseQuantity(spec.Domain.Memory.Hugepages.PageSize)
if err != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': %s",
field.Child("domain", "hugepages", "size").String(),
spec.Domain.Memory.Hugepages.PageSize,
resource.ErrFormatWrong,
),
Field: field.Child("domain", "hugepages", "size").String(),
})
} else {
vmMemory := spec.Domain.Resources.Requests.Memory().Value()
if vmMemory < hugepagesSize.Value() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' must be equal to or larger than page size %s '%s'",
field.Child("domain", "resources", "requests", "memory").String(),
spec.Domain.Resources.Requests.Memory(),
field.Child("domain", "hugepages", "size").String(),
spec.Domain.Memory.Hugepages.PageSize,
),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
} else if vmMemory%hugepagesSize.Value() != 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' is not a multiple of the page size %s '%s'",
field.Child("domain", "resources", "requests", "memory").String(),
spec.Domain.Resources.Requests.Memory(),
field.Child("domain", "hugepages", "size").String(),
spec.Domain.Memory.Hugepages.PageSize,
),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
}
}
}
// Validate hugepages
if spec.Domain.Memory != nil && spec.Domain.Memory.Guest != nil {
limits := spec.Domain.Resources.Limits.Memory().Value()
guest := spec.Domain.Memory.Guest.Value()
if limits < guest && limits != 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' must be equal to or less than the memory limit %s '%s'",
field.Child("domain", "memory", "guest").String(),
spec.Domain.Memory.Guest,
field.Child("domain", "resources", "limits", "memory").String(),
spec.Domain.Resources.Limits.Memory(),
),
Field: field.Child("domain", "memory", "guest").String(),
})
}
}
// Validate emulated machine
if len(spec.Domain.Machine.Type) > 0 {
machine := spec.Domain.Machine.Type
supportedMachines := config.GetEmulatedMachines()
var match = false
for _, val := range supportedMachines {
if regexp.MustCompile(val).MatchString(machine) {
match = true
}
}
if !match {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s is not supported: %s (allowed values: %v)",
field.Child("domain", "machine", "type").String(),
machine,
supportedMachines,
),
Field: field.Child("domain", "machine", "type").String(),
})
}
}
if spec.Domain.Firmware != nil && len(spec.Domain.Firmware.Serial) > 0 {
// Verify serial number is within valid length, if provided
if len(spec.Domain.Firmware.Serial) > maxStrLen {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must be less than or equal to %d in length, if specified",
field.Child("domain", "firmware", "serial").String(),
maxStrLen,
),
Field: field.Child("domain", "firmware", "serial").String(),
})
}
// Verify serial number is made up of valid characters for libvirt, if provided
isValid := regexp.MustCompile(`^[A-Za-z0-9_.+-]+$`).MatchString
if !isValid(spec.Domain.Firmware.Serial) {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must be made up of the following characters [A-Za-z0-9_.+-], if specified", field.Child("domain", "firmware", "serial").String()),
Field: field.Child("domain", "firmware", "serial").String(),
})
}
}
// Validate cpu if values are not negative
if spec.Domain.Resources.Requests.Cpu().MilliValue() < 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': must be greater than or equal to 0.", field.Child("domain", "resources", "requests", "cpu").String(),
spec.Domain.Resources.Requests.Cpu()),
Field: field.Child("domain", "resources", "requests", "cpu").String(),
})
}
if spec.Domain.Resources.Limits.Cpu().MilliValue() < 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s': must be greater than or equal to 0.", field.Child("domain", "resources", "limits", "cpu").String(),
spec.Domain.Resources.Limits.Cpu()),
Field: field.Child("domain", "resources", "limits", "cpu").String(),
})
}
if spec.Domain.Resources.Limits.Cpu().MilliValue() > 0 &&
spec.Domain.Resources.Requests.Cpu().MilliValue() > spec.Domain.Resources.Limits.Cpu().MilliValue() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' is greater than %s '%s'", field.Child("domain", "resources", "requests", "cpu").String(),
spec.Domain.Resources.Requests.Cpu(),
field.Child("domain", "resources", "limits", "cpu").String(),
spec.Domain.Resources.Limits.Cpu()),
Field: field.Child("domain", "resources", "requests", "cpu").String(),
})
}
// Validate CPU pinning
if spec.Domain.CPU != nil && spec.Domain.CPU.DedicatedCPUPlacement {
requestsMem := spec.Domain.Resources.Requests.Memory().Value()
limitsMem := spec.Domain.Resources.Limits.Memory().Value()
requestsCPU := spec.Domain.Resources.Requests.Cpu().Value()
limitsCPU := spec.Domain.Resources.Limits.Cpu().Value()
vCPUs := hardware.GetNumberOfVCPUs(spec.Domain.CPU)
// memory should be provided
if limitsMem == 0 && requestsMem == 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s or %s should be provided",
field.Child("domain", "resources", "requests", "memory").String(),
field.Child("domain", "resources", "limits", "memory").String(),
),
Field: field.Child("domain", "resources", "limits", "memory").String(),
})
}
// provided CPU requests must be an interger
if requestsCPU > 0 && requestsCPU*1000 != spec.Domain.Resources.Requests.Cpu().MilliValue() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "provided resources CPU requests must be an interger",
Field: field.Child("domain", "resources", "requests", "cpu").String(),
})
}
// provided CPU limits must be an interger
if limitsCPU > 0 && limitsCPU*1000 != spec.Domain.Resources.Limits.Cpu().MilliValue() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "provided resources CPU limits must be an interger",
Field: field.Child("domain", "resources", "limits", "cpu").String(),
})
}
// resources requests must be equal to limits
if requestsMem > 0 && limitsMem > 0 && requestsMem != limitsMem {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must be equal to %s",
field.Child("domain", "resources", "requests", "memory").String(),
field.Child("domain", "resources", "limits", "memory").String(),
),
Field: field.Child("domain", "resources", "requests", "memory").String(),
})
}
// cpu amount should be provided
if requestsCPU == 0 && limitsCPU == 0 && vCPUs == 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("either %s or %s or %s must be provided when DedicatedCPUPlacement is true ",
field.Child("domain", "resources", "requests", "cpu").String(),
field.Child("domain", "resources", "limits", "cpu").String(),
field.Child("domain", "cpu", "cores").String(),
),
Field: field.Child("domain", "cpu", "dedicatedCpuPlacement").String(),
})
}
// cpu amount must be provided
if requestsCPU > 0 && limitsCPU > 0 && requestsCPU != limitsCPU {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s or %s must be equal when DedicatedCPUPlacement is true ",
field.Child("domain", "resources", "requests", "cpu").String(),
field.Child("domain", "resources", "limits", "cpu").String(),
),
Field: field.Child("domain", "cpu", "dedicatedCpuPlacement").String(),
})
}
// cpu resource and cpu cores should not be provided together - unless both are equal
if (requestsCPU > 0 || limitsCPU > 0) && vCPUs > 0 &&
requestsCPU != vCPUs && limitsCPU != vCPUs {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s or %s must not be provided at the same time with %s when DedicatedCPUPlacement is true ",
field.Child("domain", "resources", "requests", "cpu").String(),
field.Child("domain", "resources", "limits", "cpu").String(),
field.Child("domain", "cpu", "cores").String(),
),
Field: field.Child("domain", "cpu", "dedicatedCpuPlacement").String(),
})
}
}
if spec.Domain.CPU != nil && spec.Domain.CPU.IsolateEmulatorThread && !spec.Domain.CPU.DedicatedCPUPlacement {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("IsolateEmulatorThread should be only set in combination with DedicatedCPUPlacement"),
Field: field.Child("domain", "cpu", "isolateEmulatorThread").String(),
})
}
// Validate CPU Feature Policies
if spec.Domain.CPU != nil && spec.Domain.CPU.Features != nil {
for idx, feature := range spec.Domain.CPU.Features {
if _, exists := validCPUFeaturePolicies[feature.Policy]; !exists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueNotSupported,
Message: fmt.Sprintf("CPU feature %s uses policy %s that is not supported.", feature.Name, feature.Policy),
Field: field.Child("domain", "cpu", "features").Index(idx).Child("policy").String(),
})
}
}
}
podNetworkInterfacePresent := false
if len(spec.Domain.Devices.Interfaces) > arrayLenMax {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s list exceeds the %d element limit in length", field.Child("domain", "devices", "interfaces").String(), arrayLenMax),
Field: field.Child("domain", "devices", "interfaces").String(),
})
return causes
} else if len(spec.Networks) > arrayLenMax {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s list exceeds the %d element limit in length", field.Child("networks").String(), arrayLenMax),
Field: field.Child("networks").String(),
})
return causes
} else if num := getNumberOfPodInterfaces(spec); num >= 1 {
podNetworkInterfacePresent = true
if num > 1 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueDuplicate,
Message: fmt.Sprintf("more than one interface is connected to a pod network in %s", field.Child("interfaces").String()),
Field: field.Child("interfaces").String(),
})
return causes
}
}
for _, volume := range spec.Volumes {
volumeNameMap[volume.Name] = &volume
}
// used to validate uniqueness of boot orders among disks and interfaces
bootOrderMap := make(map[uint]bool)
// Validate disks and volumes match up correctly
for idx, disk := range spec.Domain.Devices.Disks {
var matchingVolume *v1.Volume
matchingVolume, volumeExists := volumeNameMap[disk.Name]
if !volumeExists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' not found.", field.Child("domain", "devices", "disks").Index(idx).Child("Name").String(), disk.Name),
Field: field.Child("domain", "devices", "disks").Index(idx).Child("name").String(),
})
}
// Verify Lun disks are only mapped to network/block devices.
if disk.LUN != nil && volumeExists && matchingVolume.PersistentVolumeClaim == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s can only be mapped to a PersistentVolumeClaim volume.", field.Child("domain", "devices", "disks").Index(idx).Child("lun").String()),
Field: field.Child("domain", "devices", "disks").Index(idx).Child("lun").String(),
})
}
// verify that there are no duplicate boot orders
if disk.BootOrder != nil {
order := *disk.BootOrder
if bootOrderMap[order] {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("Boot order for %s already set for a different device.", field.Child("domain", "devices", "disks").Index(idx).Child("bootOrder").String()),
Field: field.Child("domain", "devices", "disks").Index(idx).Child("bootOrder").String(),
})
}
bootOrderMap[order] = true
}
}
multusDefaultCount := 0
podExists := false
for idx, network := range spec.Networks {
cniTypesCount := 0
// network name not needed by default
networkNameExistsOrNotNeeded := true
if network.Pod != nil {
cniTypesCount++
podExists = true
}
if network.NetworkSource.Multus != nil {
cniTypesCount++
networkNameExistsOrNotNeeded = network.Multus.NetworkName != ""
if network.NetworkSource.Multus.Default {
multusDefaultCount++
}
}
if cniTypesCount == 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: "should have a network type",
Field: field.Child("networks").Index(idx).String(),
})
} else if cniTypesCount > 1 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: "should have only one network type",
Field: field.Child("networks").Index(idx).String(),
})
}
if !networkNameExistsOrNotNeeded {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: "CNI delegating plugin must have a networkName",
Field: field.Child("networks").Index(idx).String(),
})
}
networkNameMap[spec.Networks[idx].Name] = &spec.Networks[idx]
}
if multusDefaultCount > 1 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Multus CNI should only have one default network",
Field: field.Child("networks").String(),
})
}
if podExists && multusDefaultCount > 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Pod network cannot be defined when Multus default network is defined",
Field: field.Child("networks").String(),
})
}
// Make sure interfaces and networks are 1to1 related
networkInterfaceMap := make(map[string]struct{})
// Make sure the port name is unique across all the interfaces
portForwardMap := make(map[string]struct{})
vifMQ := spec.Domain.Devices.NetworkInterfaceMultiQueue
isVirtioNicRequested := false
// Validate that each interface has a matching network
for idx, iface := range spec.Domain.Devices.Interfaces {
networkData, networkExists := networkNameMap[iface.Name]
if !networkExists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s '%s' not found.", field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(), iface.Name),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
} else if iface.Slirp != nil && networkData.Pod == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Slirp interface only implemented with pod network",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
} else if iface.Slirp != nil && networkData.Pod != nil && !config.IsSlirpInterfaceEnabled() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Slirp interface is not enabled in kubevirt-config",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
} else if iface.Masquerade != nil && networkData.Pod == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Masquerade interface only implemented with pod network",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
} else if iface.InterfaceBindingMethod.Bridge != nil && networkData.NetworkSource.Pod != nil && !config.IsBridgeInterfaceOnPodNetworkEnabled() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Bridge on pod network configuration is not enabled under kubevirt-config",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
}
// Check if the interface name is unique
if _, networkAlreadyUsed := networkInterfaceMap[iface.Name]; networkAlreadyUsed {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueDuplicate,
Message: "Only one interface can be connected to one specific network",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(),
})
}
networkInterfaceMap[iface.Name] = struct{}{}
// Check only ports configured on interfaces connected to a pod network
if networkExists && networkData.Pod != nil && iface.Ports != nil {
for portIdx, forwardPort := range iface.Ports {
if forwardPort.Port == 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: "Port field is mandatory.",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("ports").Index(portIdx).String(),
})
}
if forwardPort.Port < 0 || forwardPort.Port > 65536 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Port field must be in range 0 < x < 65536.",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("ports").Index(portIdx).String(),
})
}
if forwardPort.Protocol != "" {
if forwardPort.Protocol != "TCP" && forwardPort.Protocol != "UDP" {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Unknown protocol, only TCP or UDP allowed",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("ports").Index(portIdx).Child("protocol").String(),
})
}
} else {
forwardPort.Protocol = "TCP"
}
if forwardPort.Name != "" {
if _, ok := portForwardMap[forwardPort.Name]; ok {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueDuplicate,
Message: fmt.Sprintf("Duplicate name of the port: %s", forwardPort.Name),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("ports").Index(portIdx).Child("name").String(),
})
}
if msgs := validation.IsValidPortName(forwardPort.Name); len(msgs) != 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("Invalid name of the port: %s", forwardPort.Name),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("ports").Index(portIdx).Child("name").String(),
})
}
portForwardMap[forwardPort.Name] = struct{}{}
}
}
}
// verify that selected model is supported
if iface.Model != "" {
if _, exists := validInterfaceModels[iface.Model]; !exists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueNotSupported,
Message: fmt.Sprintf("interface %s uses model %s that is not supported.", field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(), iface.Model),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("model").String(),
})
}
}
// verify that selected macAddress is valid
if iface.MacAddress != "" {
mac, err := net.ParseMAC(iface.MacAddress)
if err != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("interface %s has malformed MAC address (%s).", field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(), iface.MacAddress),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("macAddress").String(),
})
}
if len(mac) > 6 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("interface %s has MAC address (%s) that is too long.", field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(), iface.MacAddress),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("macAddress").String(),
})
}
}
if iface.BootOrder != nil {
order := *iface.BootOrder
// Verify boot order is greater than 0, if provided
if order < 1 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must have a boot order > 0, if supplied", field.Index(idx).String()),
Field: field.Index(idx).Child("bootOrder").String(),
})
} else {
// verify that there are no duplicate boot orders
if bootOrderMap[order] {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("Boot order for %s already set for a different device.", field.Child("domain", "devices", "interfaces").Index(idx).Child("bootOrder").String()),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("bootOrder").String(),
})
}
bootOrderMap[order] = true
}
}
// verify that the specified pci address is valid
if iface.PciAddress != "" {
_, err := util.ParsePciAddress(iface.PciAddress)
if err != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("interface %s has malformed PCI address (%s).", field.Child("domain", "devices", "interfaces").Index(idx).Child("name").String(), iface.PciAddress),
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("pciAddress").String(),
})
}
}
// verify that the extra dhcp options are valid
if iface.DHCPOptions != nil {
PrivateOptions := iface.DHCPOptions.PrivateOptions
err := ValidateDuplicateDHCPPrivateOptions(PrivateOptions)
if err != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("Found Duplicates: %v", err),
Field: field.String(),
})
return causes
}
for _, DHCPPrivateOption := range PrivateOptions {
if !(DHCPPrivateOption.Option >= 224 && DHCPPrivateOption.Option <= 254) {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "provided DHCPPrivateOptions are out of range, must be in range 224 to 254",
Field: field.String(),
})
}
}
}
if iface.Model == "virtio" || iface.Model == "" {
isVirtioNicRequested = true
}
if iface.DHCPOptions != nil {
for index, ip := range iface.DHCPOptions.NTPServers {
if net.ParseIP(ip).To4() == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "NTP servers must be a list of valid IPv4 addresses.",
Field: field.Child("domain", "devices", "interfaces").Index(idx).Child("dhcpOptions", "ntpServers").Index(index).String(),
})
}
}
}
}
// Network interface multiqueue can only be set for a virtio driver
if vifMQ != nil && *vifMQ && !isVirtioNicRequested {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "virtio-net multiqueue request, but there are no virtio interfaces defined",
Field: field.Child("domain", "devices", "networkInterfaceMultiqueue").String(),
})
}
// Validate that every network was assign to an interface
networkDuplicates := map[string]struct{}{}
for i, network := range spec.Networks {
if _, exists := networkDuplicates[network.Name]; exists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueDuplicate,
Message: fmt.Sprintf("Network with name %q already exists, every network must have a unique name", network.Name),
Field: field.Child("networks").Index(i).Child("name").String(),
})
}
networkDuplicates[network.Name] = struct{}{}
if _, exists := networkInterfaceMap[network.Name]; !exists {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: fmt.Sprintf("%s '%s' not found.", field.Child("networks").Index(i).Child("name").String(), network.Name),
Field: field.Child("networks").Index(i).Child("name").String(),
})
}
}
for idx, input := range spec.Domain.Devices.Inputs {
if input.Bus != "virtio" && input.Bus != "usb" && input.Bus != "" {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Input device can have only virtio or usb bus.",
Field: field.Child("domain", "devices", "inputs").Index(idx).Child("bus").String(),
})
}
if input.Type != "tablet" {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "Input device can have only tablet type.",
Field: field.Child("domain", "devices", "inputs").Index(idx).Child("type").String(),
})
}
}
if spec.Domain.IOThreadsPolicy != nil {
isValidPolicy := func(policy v1.IOThreadsPolicy) bool {
for _, p := range validIOThreadsPolicies {
if policy == p {
return true
}
}
return false
}
if !isValidPolicy(*spec.Domain.IOThreadsPolicy) {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("Invalid IOThreadsPolicy (%s)", *spec.Domain.IOThreadsPolicy),
Field: field.Child("domain", "ioThreadsPolicy").String(),
})
}
}
if spec.ReadinessProbe != nil {
if spec.ReadinessProbe.HTTPGet != nil && spec.ReadinessProbe.TCPSocket != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must have exactly one probe type set", field.Child("readinessProbe").String()),
Field: field.Child("readinessProbe").String(),
})
} else if spec.ReadinessProbe.HTTPGet == nil && spec.ReadinessProbe.TCPSocket == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: fmt.Sprintf("either %s or %s must be set if a %s is specified",
field.Child("readinessProbe", "tcpSocket").String(),
field.Child("readinessProbe", "httpGet").String(),
field.Child("readinessProbe").String(),
),
Field: field.Child("readinessProbe").String(),
})
}
}
if spec.LivenessProbe != nil {
if spec.LivenessProbe.HTTPGet != nil && spec.LivenessProbe.TCPSocket != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s must have exactly one probe type set", field.Child("livenessProbe").String()),
Field: field.Child("livenessProbe").String(),
})
} else if spec.LivenessProbe.HTTPGet == nil && spec.LivenessProbe.TCPSocket == nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: fmt.Sprintf("either %s or %s must be set if a %s is specified",
field.Child("livenessProbe", "tcpSocket").String(),
field.Child("livenessProbe", "httpGet").String(),
field.Child("livenessProbe").String(),
),
Field: field.Child("livenessProbe").String(),
})
}
}
if !podNetworkInterfacePresent {
if spec.LivenessProbe != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s is only allowed if the Pod Network is attached", field.Child("livenessProbe").String()),
Field: field.Child("livenessProbe").String(),
})
}
if spec.ReadinessProbe != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s is only allowed if the Pod Network is attached", field.Child("readinessProbe").String()),
Field: field.Child("readinessProbe").String(),
})
}
}
causes = append(causes, validateDomainSpec(field.Child("domain"), &spec.Domain)...)
causes = append(causes, validateVolumes(field.Child("volumes"), spec.Volumes, config)...)
if spec.DNSPolicy != "" {
causes = append(causes, validateDNSPolicy(&spec.DNSPolicy, field.Child("dnsPolicy"))...)
}
causes = append(causes, validatePodDNSConfig(spec.DNSConfig, &spec.DNSPolicy, field.Child("dnsConfig"))...)
if !config.LiveMigrationEnabled() && spec.EvictionStrategy != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "LiveMigration feature gate is not enabled",
Field: field.Child("evictionStrategy").String(),
})
} else if spec.EvictionStrategy != nil {
if *spec.EvictionStrategy != v1.EvictionStrategyLiveMigrate {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("%s is set with an unrecognized option: %s", field.Child("evictionStrategy").String(), *spec.EvictionStrategy),
Field: field.Child("evictionStrategy").String(),
})
}
} else if *spec.EvictionStrategy == v1.EvictionStrategyLiveMigrate {
for _, iface := range spec.Domain.Devices.Interfaces {
if iface.SRIOV != nil {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "SRIOV interfaces are incompatible with the LiveMigrate eviction strategy",
Field: field.Child("evictionStrategy").String(),
})
}
}
if spec.Domain.Devices.GPUs != nil && len(spec.Domain.Devices.GPUs) > 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: "GPU passthrough is incompatible with the LiveMigrate eviction strategy",
Field: field.Child("evictionStrategy").String(),
})
}
}
if spec.Domain.Devices.GPUs != nil && !config.GPUPassthroughEnabled() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,
Message: fmt.Sprintf("GPU feature gate is not enabled in kubevirt-config"),
Field: field.Child("GPUs").String(),
})
}
return causes
}
// ValidateVirtualMachineInstanceMandatoryFields should be invoked after all defaults and presets are applied.
// It is only meant to be used for VMI reviews, not if they are templates on other objects
func ValidateVirtualMachineInstanceMandatoryFields(field *k8sfield.Path, spec *v1.VirtualMachineInstanceSpec) []metav1.StatusCause {
var causes []metav1.StatusCause
requests := spec.Domain.Resources.Requests.Memory().Value()
if requests == 0 &&
(spec.Domain.Memory == nil || spec.Domain.Memory != nil &&
spec.Domain.Memory.Guest == nil && spec.Domain.Memory.Hugepages == nil) {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueRequired,
Message: fmt.Sprintf("no memory requested, at least one of '%s', '%s' or '%s' must be set",
field.Child("domain", "memory", "guest").String(),
field.Child("domain", "memory", "hugepages", "size").String(),
field.Child("domain", "resources", "requests", "memory").String()),
})
}
return causes
}
func ValidateVirtualMachineInstanceMetadata(field *k8sfield.Path, metadata *metav1.ObjectMeta, config *virtconfig.ClusterConfig, accountName string) []metav1.StatusCause {
var causes []metav1.StatusCause
annotations := metadata.Annotations
labels := metadata.Labels
// Validate kubevirt.io labels presence. Restricted labels allowed
// to be created only by known service accounts
allowed := getAllowedServiceAccounts()
if _, ok := allowed[accountName]; !ok {
if len(filterKubevirtLabels(labels)) > 0 {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueNotSupported,
Message: "creation of the following reserved kubevirt.io/ labels on a VMI object is prohibited",
Field: field.Child("labels").String(),
})
}
}
// Validate ignition feature gate if set when the corresponding annotation is found
if annotations[v1.IgnitionAnnotation] != "" && !config.IgnitionEnabled() {
causes = append(causes, metav1.StatusCause{
Type: metav1.CauseTypeFieldValueInvalid,