-
Notifications
You must be signed in to change notification settings - Fork 1.3k
/
vmi-mutator.go
292 lines (259 loc) · 10.3 KB
/
vmi-mutator.go
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
/*
* This file is part of the KubeVirt project
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*
* Copyright 2018 Red Hat, Inc.
*
*/
package mutators
import (
"encoding/json"
"fmt"
"net/http"
"reflect"
"strings"
"k8s.io/api/admission/v1beta1"
k8sv1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
v1 "kubevirt.io/client-go/api/v1"
"kubevirt.io/client-go/log"
webhookutils "kubevirt.io/kubevirt/pkg/util/webhooks"
"kubevirt.io/kubevirt/pkg/virt-api/webhooks"
virtconfig "kubevirt.io/kubevirt/pkg/virt-config"
)
type VMIsMutator struct {
ClusterConfig *virtconfig.ClusterConfig
}
func (mutator *VMIsMutator) Mutate(ar *v1beta1.AdmissionReview) *v1beta1.AdmissionResponse {
if !webhookutils.ValidateRequestResource(ar.Request.Resource, webhooks.VirtualMachineInstanceGroupVersionResource.Group, webhooks.VirtualMachineInstanceGroupVersionResource.Resource) {
err := fmt.Errorf("expect resource to be '%s'", webhooks.VirtualMachineInstanceGroupVersionResource.Resource)
return webhookutils.ToAdmissionResponseError(err)
}
if resp := webhookutils.ValidateSchema(v1.VirtualMachineInstanceGroupVersionKind, ar.Request.Object.Raw); resp != nil {
return resp
}
// Get new VMI from admission response
newVMI, oldVMI, err := webhookutils.GetVMIFromAdmissionReview(ar)
if err != nil {
return webhookutils.ToAdmissionResponseError(err)
}
var patch []patchOperation
// Patch the spec with defaults if we deal with a create operation
if ar.Request.Operation == v1beta1.Create {
informers := webhooks.GetInformers()
// Apply presets
err = applyPresets(newVMI, informers.VMIPresetInformer)
if err != nil {
return &v1beta1.AdmissionResponse{
Result: &metav1.Status{
Message: err.Error(),
Code: http.StatusUnprocessableEntity,
},
}
}
// Apply namespace limits
applyNamespaceLimitRangeValues(newVMI, informers.NamespaceLimitsInformer)
// Set VMI defaults
log.Log.Object(newVMI).V(4).Info("Apply defaults")
mutator.setDefaultCPUModel(newVMI)
mutator.setDefaultMachineType(newVMI)
mutator.setDefaultResourceRequests(newVMI)
mutator.setDefaultGuestCPUTopology(newVMI)
mutator.setDefaultPullPoliciesOnContainerDisks(newVMI)
err = mutator.setDefaultNetworkInterface(newVMI)
if err != nil {
return webhookutils.ToAdmissionResponseError(err)
}
v1.SetObjectDefaults_VirtualMachineInstance(newVMI)
// In a future, yet undecided, release either libvirt or QEMU are going to check the hyperv dependencies, so we can get rid of this code.
// Until that time, we need to handle the hyperv deps to avoid obscure rejections from QEMU later on
log.Log.V(4).Info("Set HyperV dependencies")
err = webhooks.SetVirtualMachineInstanceHypervFeatureDependencies(newVMI)
if err != nil {
// HyperV is a special case. If our best-effort attempt fails, we should leave
// rejection to be performed later on in the validating webhook, and continue here.
// Please note this means that partial changes may have been performed.
// This is OK since each dependency must be atomic and independent (in ACID sense),
// so the VMI configuration is still legal.
log.Log.V(2).Infof("Failed to set HyperV dependencies: %s", err)
}
// Add foreground finalizer
newVMI.Finalizers = append(newVMI.Finalizers, v1.VirtualMachineInstanceFinalizer)
var value interface{}
value = newVMI.Spec
patch = append(patch, patchOperation{
Op: "replace",
Path: "/spec",
Value: value,
})
value = newVMI.ObjectMeta
patch = append(patch, patchOperation{
Op: "replace",
Path: "/metadata",
Value: value,
})
} else if ar.Request.Operation == v1beta1.Update {
// Ignore status updates if they are not coming from our service accounts
// TODO: As soon as CRDs support field selectors we can remove this and just enable
// the status subresource. Until then we need to update Status and Metadata labels in parallel for e.g. Migrations.
if !reflect.DeepEqual(newVMI.Status, oldVMI.Status) {
if !webhooks.IsKubeVirtServiceAccount(ar.Request.UserInfo.Username) {
patch = append(patch, patchOperation{
Op: "replace",
Path: "/status",
Value: oldVMI.Status,
})
}
}
}
patchBytes, err := json.Marshal(patch)
if err != nil {
return webhookutils.ToAdmissionResponseError(err)
}
jsonPatchType := v1beta1.PatchTypeJSONPatch
return &v1beta1.AdmissionResponse{
Allowed: true,
Patch: patchBytes,
PatchType: &jsonPatchType,
}
}
func (mutator *VMIsMutator) setDefaultNetworkInterface(obj *v1.VirtualMachineInstance) error {
autoAttach := obj.Spec.Domain.Devices.AutoattachPodInterface
if autoAttach != nil && *autoAttach == false {
return nil
}
// Override only when nothing is specified
if len(obj.Spec.Networks) == 0 && len(obj.Spec.Domain.Devices.Interfaces) == 0 {
iface := v1.NetworkInterfaceType(mutator.ClusterConfig.GetDefaultNetworkInterface())
switch iface {
case v1.BridgeInterface:
if !mutator.ClusterConfig.IsBridgeInterfaceOnPodNetworkEnabled() {
return fmt.Errorf("Bridge interface is not enabled in kubevirt-config")
}
obj.Spec.Domain.Devices.Interfaces = []v1.Interface{*v1.DefaultBridgeNetworkInterface()}
case v1.MasqueradeInterface:
obj.Spec.Domain.Devices.Interfaces = []v1.Interface{*v1.DefaultMasqueradeNetworkInterface()}
case v1.SlirpInterface:
if !mutator.ClusterConfig.IsSlirpInterfaceEnabled() {
return fmt.Errorf("Slirp interface is not enabled in kubevirt-config")
}
defaultIface := v1.DefaultSlirpNetworkInterface()
obj.Spec.Domain.Devices.Interfaces = []v1.Interface{*defaultIface}
}
obj.Spec.Networks = []v1.Network{*v1.DefaultPodNetwork()}
}
return nil
}
func (mutator *VMIsMutator) setDefaultCPUModel(vmi *v1.VirtualMachineInstance) {
//if vmi doesn't have cpu topology or cpu model set
if vmi.Spec.Domain.CPU == nil || vmi.Spec.Domain.CPU.Model == "" {
if defaultCPUModel := mutator.ClusterConfig.GetCPUModel(); defaultCPUModel != "" {
// create cpu topology struct
if vmi.Spec.Domain.CPU == nil {
vmi.Spec.Domain.CPU = &v1.CPU{}
}
//set is as vmi cpu model
vmi.Spec.Domain.CPU.Model = defaultCPUModel
}
}
}
func (mutator *VMIsMutator) setDefaultGuestCPUTopology(vmi *v1.VirtualMachineInstance) {
cores := uint32(1)
threads := uint32(1)
sockets := uint32(1)
vmiCPU := vmi.Spec.Domain.CPU
if vmiCPU == nil || (vmiCPU.Cores == 0 && vmiCPU.Sockets == 0 && vmiCPU.Threads == 0) {
// create cpu topology struct
if vmi.Spec.Domain.CPU == nil {
vmi.Spec.Domain.CPU = &v1.CPU{}
}
//if cores, sockets, threads are not set, take value from domain resources request or limits and
//set value into sockets, which have best performance (https://bugzilla.redhat.com/show_bug.cgi?id=1653453)
resources := vmi.Spec.Domain.Resources
if cpuLimit, ok := resources.Limits[k8sv1.ResourceCPU]; ok {
sockets = uint32(cpuLimit.Value())
} else if cpuRequests, ok := resources.Requests[k8sv1.ResourceCPU]; ok {
sockets = uint32(cpuRequests.Value())
}
vmi.Spec.Domain.CPU.Sockets = sockets
vmi.Spec.Domain.CPU.Cores = cores
vmi.Spec.Domain.CPU.Threads = threads
}
}
func (mutator *VMIsMutator) setDefaultMachineType(vmi *v1.VirtualMachineInstance) {
if vmi.Spec.Domain.Machine.Type == "" {
vmi.Spec.Domain.Machine.Type = mutator.ClusterConfig.GetMachineType()
}
}
func (mutator *VMIsMutator) setDefaultPullPoliciesOnContainerDisks(vmi *v1.VirtualMachineInstance) {
for _, volume := range vmi.Spec.Volumes {
if volume.ContainerDisk != nil && volume.ContainerDisk.ImagePullPolicy == "" {
if strings.HasSuffix(volume.ContainerDisk.Image, ":latest") || !strings.ContainsAny(volume.ContainerDisk.Image, ":@") {
volume.ContainerDisk.ImagePullPolicy = k8sv1.PullAlways
} else {
volume.ContainerDisk.ImagePullPolicy = k8sv1.PullIfNotPresent
}
}
}
}
func (mutator *VMIsMutator) setDefaultResourceRequests(vmi *v1.VirtualMachineInstance) {
resources := &vmi.Spec.Domain.Resources
if !resources.Limits.Cpu().IsZero() && resources.Requests.Cpu().IsZero() {
if resources.Requests == nil {
resources.Requests = k8sv1.ResourceList{}
}
resources.Requests[k8sv1.ResourceCPU] = resources.Limits[k8sv1.ResourceCPU]
}
if !resources.Limits.Memory().IsZero() && resources.Requests.Memory().IsZero() {
if resources.Requests == nil {
resources.Requests = k8sv1.ResourceList{}
}
resources.Requests[k8sv1.ResourceMemory] = resources.Limits[k8sv1.ResourceMemory]
}
if _, exists := resources.Requests[k8sv1.ResourceMemory]; !exists {
var memory *resource.Quantity
if vmi.Spec.Domain.Memory != nil && vmi.Spec.Domain.Memory.Guest != nil {
memory = vmi.Spec.Domain.Memory.Guest
}
if memory == nil && vmi.Spec.Domain.Memory != nil && vmi.Spec.Domain.Memory.Hugepages != nil {
if hugepagesSize, err := resource.ParseQuantity(vmi.Spec.Domain.Memory.Hugepages.PageSize); err == nil {
memory = &hugepagesSize
}
}
if memory != nil && memory.Value() > 0 {
if resources.Requests == nil {
resources.Requests = k8sv1.ResourceList{}
}
overcommit := mutator.ClusterConfig.GetMemoryOvercommit()
if overcommit == 100 {
resources.Requests[k8sv1.ResourceMemory] = *memory
} else {
value := (memory.Value() * int64(100)) / int64(overcommit)
resources.Requests[k8sv1.ResourceMemory] = *resource.NewQuantity(value, memory.Format)
}
memoryRequest := resources.Requests[k8sv1.ResourceMemory]
log.Log.Object(vmi).V(4).Infof("Set memory-request to %s as a result of memory-overcommit = %v%%", memoryRequest.String(), overcommit)
}
}
if _, exists := resources.Requests[k8sv1.ResourceCPU]; !exists {
if vmi.Spec.Domain.CPU != nil && vmi.Spec.Domain.CPU.DedicatedCPUPlacement {
return
}
if resources.Requests == nil {
resources.Requests = k8sv1.ResourceList{}
}
resources.Requests[k8sv1.ResourceCPU] = *mutator.ClusterConfig.GetCPURequest()
}
}