Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Skip() with Except() #11632

Open
RoniKishner opened this issue Apr 2, 2024 · 0 comments
Open

Replace Skip() with Except() #11632

RoniKishner opened this issue Apr 2, 2024 · 0 comments

Comments

@RoniKishner
Copy link
Contributor

Is your feature request related to a problem? Please describe:
Currently there are places in the code tests folder that skips the test when a storageClass/Hardware doesn't exists, however those tests already have a [storage-req] label and similar [req] labels on them, causing the skip to be either unnecessary or might lead to a bug being skipped.

Describe the solution you'd like:

  • Remove any Skip() test that is labelled with [req], and replace them with Except() if needed.
  • Add [req] label to the tests that are missing those so we could later remove additional Skip() calls.

An example:

if !foundSC {
  Skip("Skip test when Filesystem storage is not present")

Replaced with:
Expect(foundSC)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant