Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement validation webhooks for ClusterAdmissionPolicy #69

Closed
flavio opened this issue Sep 8, 2021 · 2 comments
Closed

Implement validation webhooks for ClusterAdmissionPolicy #69

flavio opened this issue Sep 8, 2021 · 2 comments
Assignees
Projects

Comments

@flavio
Copy link
Member

flavio commented Sep 8, 2021

We must provide a mutation webhook for the ClusterAdmissionPolicy resource.

The webhook will implement the following validations:

  • UPDATE operation: do not allow to change the name of the policy server where the policy is scheduled. If the user wants to change it he will have to delete the policy and create a new one. At least for now

The webhook will implement the following mutations:

  • CREATE operation: ensure the kubewarden finalizers are specified, if not, add them
  • CREATE operation: set the policyStatus to pending when a ClusterAdmissionPolicy is created

Note well: it's totally fine to create a ClusterAdmissionPolicy object that is scheduled on a non-existing PolicyServer.

@raulcabello
Copy link
Contributor

I just updated the card to set the policy status to unscheduled more info #72

@flavio flavio moved this from In progress to Pending review in Development Sep 17, 2021
@flavio flavio moved this from Pending review to In progress in Development Sep 17, 2021
@viccuad
Copy link
Member

viccuad commented Sep 20, 2021

Closed by #76.

@viccuad viccuad closed this as completed Sep 20, 2021
@viccuad viccuad moved this from In progress to Done in Development Sep 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development
Done (weekly)
Development

No branches or pull requests

3 participants