Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

update haproxy tag to the version for caasp4 #747

Closed
wants to merge 1 commit into from

Conversation

jordimassaguerpla
Copy link
Member

Signed-off-by: Jordi Massaguer Pla jmassaguerpla@suse.de

@jordimassaguerpla
Copy link
Member Author

This needs to go together with SUSE/caasp-container-manifests#221

@jordimassaguerpla
Copy link
Member Author

@MaximilianMeister : will it be ok for you that we merge both Requests? I don't think tests can pass separately...

@MalloZup
Copy link
Contributor

MalloZup commented Feb 20, 2019

there is a an hackish way to test 2 prs (from 2 diff repos) before merging. you can do this in the repo jenkins-library with a PR and from there specify your salt and other repos, i think we could do it before merging.

@jordimassaguerpla
Copy link
Member Author

@MalloZup that sounds great! Could you do that for me? Unfortunately I am not familiar enough with the CI setup to do this hack ... I would really appreciate since this is the last thing needed for the next release.

salt/haproxy/haproxy.yaml.jinja Show resolved Hide resolved
@MalloZup
Copy link
Contributor

MalloZup commented Feb 21, 2019

Copy link

@MaximilianMeister MaximilianMeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok for merging as is, if we follow up on the pillar setting in another PR

@MalloZup MalloZup mentioned this pull request Feb 21, 2019
@MalloZup
Copy link
Contributor

@MaximilianMeister i have done the Pipeline for the 2 prs, is running now:
http://jenkins.caasp.suse.net/blue/organizations/jenkins/jenkins-library.integration/detail/PR-276/5/pipeline

if green we can merge. I have created follow-up issue

MalloZup
MalloZup previously approved these changes Feb 21, 2019
Copy link
Contributor

@MalloZup MalloZup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐷 wait for the other pipeline otherwise ok

@hwoarang
Copy link
Contributor

@MaximilianMeister i have done the Pipeline for the 2 prs, is running now:
http://jenkins.caasp.suse.net/blue/organizations/jenkins/jenkins-library.integration/detail/PR-276/5/pipeline

if green we can merge. I have created follow-up issue

@MalloZup where is the follow up issue?

@MalloZup
Copy link
Contributor

it is in between comments @hwoarang ⚙️ it is here: #748

Signed-off-by: Jordi Massaguer Pla <jmassaguerpla@suse.de>
@MaximilianMeister
Copy link

I cherry-picked into #750

@MaximilianMeister MaximilianMeister deleted the use_caasp_v4_images_from_registry branch February 26, 2019 15:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants