Skip to content
This repository has been archived by the owner on Oct 29, 2019. It is now read-only.

Public Cloud fixes #488

Merged
merged 4 commits into from Apr 9, 2018
Merged

Public Cloud fixes #488

merged 4 commits into from Apr 9, 2018

Conversation

bear454
Copy link
Member

@bear454 bear454 commented Apr 5, 2018

  • An pillar for Azure storage account name was described as optional in the documentation, but in practice is required.
  • Improve the layout of inputs in public cloud forms.
  • Add an explanatory link on Azure service principal attributes.

@bear454
Copy link
Member Author

bear454 commented Apr 5, 2018

Public Cloud fixes

@vitoravelino
Copy link
Contributor

Since you are fixing smaller things, what about adding the cursor: pointer to .instance-type-box that I've mentioned in the past? ;)

@bear454
Copy link
Member Author

bear454 commented Apr 9, 2018

@vitoravelino if Jenkins fails for some reason, because I added 16 chars of CSS... I'm blaming you. 😛

Copy link
Contributor

@ereslibre ereslibre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vitoravelino vitoravelino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ereslibre ereslibre merged commit cf9fe3c into SUSE:master Apr 9, 2018
@bear454 bear454 deleted the azure-add-storage-account branch April 9, 2018 18:58
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants