Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-Wimplicit-function-declaration and -Wint-conversion when compiling under MinGW x64 #7

Closed
alextwothousand opened this issue Dec 22, 2020 · 1 comment

Comments

@alextwothousand
Copy link

C:\Users\alex\CLionProjects\SDScriptHook\vendor\dllinjector\src\windows\injector.c: In function 'funcaddr':
C:\Users\alex\CLionProjects\SDScriptHook\vendor\dllinjector\src\windows\injector.c:395:12: warning: implicit declaration of function 'bsearch_s'; did you mean 'bsearch'? [-Wimplicit-function-declaration]
  395 |     name = bsearch_s((void*)"LoadLibraryW", names, exp->NumberOfNames, sizeof(DWORD), cmp_func, (void*)rva_to_va);
      |            ^~~~~~~~~
      |            bsearch
C:\Users\alex\CLionProjects\SDScriptHook\vendor\dllinjector\src\windows\injector.c:395:10: warning: assignment to 'const DWORD *' {aka 'const long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
  395 |     name = bsearch_s((void*)"LoadLibraryW", names, exp->NumberOfNames, sizeof(DWORD), cmp_func, (void*)rva_to_va);
      |          ^
C:\Users\alex\CLionProjects\SDScriptHook\vendor\dllinjector\src\windows\injector.c:403:10: warning: assignment to 'const DWORD *' {aka 'const long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
  403 |     name = bsearch_s((void*)"FreeLibrary", names, exp->NumberOfNames, sizeof(DWORD), cmp_func, (void*)rva_to_va);
      |          ^
C:\Users\alex\CLionProjects\SDScriptHook\vendor\dllinjector\src\windows\injector.c:411:10: warning: assignment to 'const DWORD *' {aka 'const long unsigned int *'} from 'int' makes pointer from integer without a cast [-Wint-conversion]
  411 |     name = bsearch_s((void*)"GetLastError", names, exp->NumberOfNames, sizeof(DWORD), cmp_func, (void*)rva_to_va);
      |          ^
@kubo kubo closed this as completed in 0da82ea Dec 30, 2020
@kubo
Copy link
Owner

kubo commented Dec 30, 2020

Thanks for the report. I fixed it.
Mingw32 compiler doesn't support msvc-specific function bsearch_s. So injector now uses liner search instead of binary search.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants