Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Create Obsidian Links to Bible Verses" does not like to my verses accurately #19

Closed
cjolson opened this issue Sep 15, 2022 · 2 comments
Labels
enhancement New feature or request wontfix This will not be worked on

Comments

@cjolson
Copy link

cjolson commented Sep 15, 2022

When I use the Copy Bible Verses action, it accommodates my file formats for the individual verses by adding the - in the file tile and including the v prefix for verses.

[[Gn-01#v1|Gn 1:1-2]] 
In the beginning God created the heavens and the earth. 
The earth was without form and void, and darkness was upon the face of the deep; and the Spirit of God was moving over the face of the waters. 
[[Gn-01#v1|]][[Gn-01#v2|]]

However, when I use the Create Obsidian Links to Bible Verses action, it does not:

[[Gn 1#1]]
[[Gn 1#2]]

You'll notice the difference between [[Gn-01#v1|]] and [[Gn 1#1]].

  • It doesn't add the - in between the books and the chapter
  • It doesn't add the v as a prefix for the verse (this one I can fix by using #v as my Link Separator, but it's weird that it behaves differently than the invisible link for the Copy Bible Verses action)
@kuchejak
Copy link
Owner

The two commands actually work very differently, so there are some differences like this one. The copy command looks into the files and can get some additional information from them (like the 'v' verse prefix). The link command, on the other hand, is a very simple text parser that does not work with the file content at all — I made this command primarily for people who are unable to use the Copy command.

The automatic usage of '-' could be added to the linking command as well, but I want to first add support for multiple Bible translations to the Copy command. 

@kuchejak kuchejak added the enhancement New feature or request label Sep 15, 2022
@kuchejak
Copy link
Owner

kuchejak commented Oct 8, 2022

Hi, I have looked into the code and it seems to me that this small improvement would take more time to implement than I would like to spend on it. I believe that the link command serves its purpose for people who are unable to use the copy command, and I don't plan to add more features to it (at least for now).

If the '-' character in filenames is causing you problems, I recommend removing it. I'm sure you can find some free tools for renaming multiple files at once. 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants