Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow non-verse headings in between verses #8

Merged
merged 4 commits into from Apr 24, 2022
Merged

Allow non-verse headings in between verses #8

merged 4 commits into from Apr 24, 2022

Conversation

Castlepool
Copy link
Contributor

@Castlepool Castlepool commented Apr 23, 2022

Thanks a lot for your efforts to develop this plugin, I really like it!

Two things didn't work for my markdown bible when trying to "Copy Bible verses".
With this pull request I'd like to fix these.

1. Support having headings (of higher level) in between verses

###### 1
1st verse text

## Some helpful heading that is not a verse number

###### 2
2nd verse text

###### 3
3rd verse text

=> Support added by new setting to specify which heading level to search for when copying verses.

2. Support empty line between verse heading and verse text

Because I format my markdown to have an empty line underneath each heading:

###### 1

1st verse text

###### 2

2st verse text

If these cases seem to specific to you, feel free to say so or only use part of it :)

@kuchejak
Copy link
Owner

Hi, thank you very much for your PR! It is a good addition and it seems to work great.

I have just one small request, could you please change the setting to a dropdown (combo box)? I think it will be a little bit easier to use that way.

@Castlepool
Copy link
Contributor Author

Hello, thanks for your quick response and feedback. I made the setting a dropdown now, good idea!
(and also fixed a typo in one of the other settings)

@kuchejak kuchejak merged commit 81ff86a into kuchejak:main Apr 24, 2022
@kuchejak
Copy link
Owner

Looks great, thank you for contributing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants