-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow usage of "--force" to apply updates to KUDO managed resources #1335
Comments
I'm not sure that adding a |
Another option would be to have the |
Which flag? This is the first time a flag is being mentioned in this description.
? In that case I think it would be quite surprising and contrary to established conventions, if a controller was to mutate the |
Yes, I meant the field. And changing the spec... It's what's currently happens with the I do agree that it's a bit unconventional. Any other ideas to pass a one-off flag for a parameter update to the controller would be very welcome |
As mentioned in #1332 that PR introduces a backwards incompatible change.
This issue tries to provide a solution to handle that issue and some others.
What would you like to be added:
A
--force
parameter to use onk kudo update
Why is this needed:
This would allow the apply task in KUDO to handle a failure while patching a resource. This failure can have multiple sources:
This approach would mirror the handling of
kubectl apply
most closely.It would require to add a new field on the InstanceSpec to specify that the last update to the parameter set is expected to be force-applied. When the instance controller starts the plan execution, it clears this flag and incorporates it into the current plan execution.
Old idea
Certain updates to resources are not allowed by k8s. The
kubectl apply
provides a--force
flag to still deploy those changes. In the background it schedules a delete/create for this instead of applying a patch.We could have the same flag on an "Apply" Task to allow disruptive updates to resources. At the moment the only way to update those attributes is to manually write an "update" plan that deletes and recreates the resources.
The text was updated successfully, but these errors were encountered: