Kustomize Label Additions prevent services from finding Deployments

[runyontr]

Kustomize provides a feature to automatically add the labels on the service object into the selector spec. This typically provides consistency for objects created, but can cause issues for pods created from a different STEP than the service:

Consider the following:

 plans:
    deploy:
      strategy: serial
      phases:
        - name: all
          strategy: parallel
          steps:
            - name: services
              tasks:
              - services
            - name: deployment
              tasks:
              - deployment

The service object

    service.yaml: |
      apiVersion: v1
      kind: Service
      metadata:
        name: appinfo
        labels:
          app: appinfo
      spec:
        ports:
        - port: 8080
          protocol: TCP
        selector:
          app: appinfo
        type: LoadBalancer

Has the following label selectors:

$ kubectl get svc bird-appinfo -o jsonpath="{.spec.selector['step']}"
services

whereas the deployment gets created with the following label

$kubectl get deployments bird-appinfo -o jsonpath="{ .metadata.labels['step']}"
deployment

This added label for the specific step was added to be able to differentiate Jobs that need to be re-created even when they have the same name.

[runyontr]

Blocking for #70

[alenkacz]

we no longer put step into labels