Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Week numbering with Sunday start of week #87

Open
TK0343 opened this issue Jun 30, 2023 · 1 comment
Open

Week numbering with Sunday start of week #87

TK0343 opened this issue Jun 30, 2023 · 1 comment

Comments

@TK0343
Copy link

TK0343 commented Jun 30, 2023

The numbering of the week does not change when using Sunday as the start of the week resulting in behavior such as in March in the image below. Any time there is a week consisting of just a Sunday on a monthly calendar it uses the previous week value instead of the next week as one would expect. This is also represented on the daily page for that date.

Screenshot_20230630-165647_ASUS_Launcher (1)

@kudrykv
Copy link
Owner

kudrykv commented Jul 1, 2023

@TK0343 oh I see. Yes, it makes sense to change the week number there.

The reason it happens now is the week number is based on ISO week numbering. Sunday still belongs to week 13, and as there are no more days in the given week, the algorithm picks up the only available day in the week and gets its week number.

Thank you for the report, I'll look into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants