fix: add aria-label to MessageScreen #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cidermitaina
requested review from
nabeliwo and
Tokky0425
and removed request for
a team
|
Deploy preview for smarthr-ui ready! Built with commit 9d8d92a |
|
✨✨ That's perfect, there is no visual difference! ✨✨ Check out the report here. |
cidermitaina
changed the title
|
@nabeliwo @Tokky0425 |
nabeliwo
reviewed
Sep 29, 2020
| @@ -39,7 +39,7 @@ export const MessageScreen: FC<Props> = ({ title, links, children, className = ' | |||
| <li key={link.label}> | |||
| <Link | |||
| href={link.url} | |||
| {...(link.target ? { target: link.target } : {})} | |||
| {...(link.target ? { target: link.target, 'aria-label': '別タブで開く' } : {})} | |||
There was a problem hiding this comment.
[MUST] PR の説明を見ると「target=_blank の時に 'aria-label': '別タブで開く' を追加する」という条件のようですが、現状だと「target が存在した場合 target の値とは関係なく 'aria-label': '別タブで開く' を追加する」という記述になっているようです。
There was a problem hiding this comment.
ほんとだ…！🙇♀️
こちらで修正しましたのでご確認お願いします！
5e4d235
|
@nabeliwo |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related URL
https://smarthr.atlassian.net/browse/SHRUI-152
Overview
MessageScreen--fullのtarget=_blankなリンクが達成基準 1.1.1 非テキストコンテンツに非適合なのでaria-labelを追加しました。What I did
MessageScreen--fullのtarget=_blankリンクにaria-label="別タブで開く"を追加Capture