feat: add tooltip component #738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for smarthr-ui ready! Built with commit ee74e74 |
Tokky0425
requested changes
Apr 17, 2020
nabeliwo
reviewed
Apr 17, 2020
There was a problem hiding this comment.
レビュワーではないのですが2点気になったのでコメントします！
-
テスト落ちているのでマージ前に対応されるとは思いますが、ユーザから使えるようにルートの index.ts で Tooltip component の export をお願いします 🙏
-
Tooltip の対象となる要素が右側にある場合に現状だとこのように見切れてしまいます。
対応としては、要素の位置に応じて自動で Tooltip 自体の位置や矢印の位置が適切になるよう調整するか、ユーザにどの位置に矢印を表示させるか(「左下」や「右下」など)を props で指定させるか、みたいなのが必要そうです！
AtsushiM
changed the title
AtsushiM
force-pushed
the
add-tooltip-module
branch
from
8b948db
to
b65e61f
Compare
|
@nabeliwo @Tokky0425
|
Tokky0425
previously approved these changes
Apr 28, 2020
|
@Tokky0425 @nabeliwo masuP9さんの指摘内容、対応しましたので改めてreviewお願いします 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tooltip Componentを追加します。