feat!: stylelint v14 を peerDependencies から除外、v15 のルールに移行 #205
+83
−327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf. [Migrating to 15.0.0](https://stylelint.io/migration-guide/to-15/) - stylelint v14 を peerDependencies から除外 - warning が出るルールを削除 - postcss-jsx から postcss-styled-syntax への移行
f440
requested review from
nabeliwo,
TakahiroHimi and
diescake
and removed request for
a team
diescake
changed the title
diescake
reviewed
May 10, 2023
|
PRありがとうございます！！ あと、BREAKING CHANGESを含むのでタイトルにconventional commitsの作法でタイトルに |
diescake
approved these changes
May 10, 2023
Co-authored-by: Daisuke Kondo <gachapining@gmail.com>
|
確認＆指摘どもです！マージしました！ |
f440
commented
May 12, 2023
| ], | ||
| customSyntax: 'postcss-jsx', |
There was a problem hiding this comment.
- postcss-jsx が生まれる
- 更新が止まる
- stylelintがpostcss-css-in-jsとしてフォークする
- postcss-css-in-jsもアーカイブされ、乗り換えを促される
という流れを踏まえて変更しています。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stylelint v14 から v15 で大きく方針変更が発生しており、stylelint v15 系を利用すると peerDependencies を満たすことができなくなっています。
stylelint v14 系のサポートをやめ、ドキュメントをもとに v15 系の設定に移行しました。 cf. Migrating to 15.0.0 | Stylelint
本PRは非互換な変更になります。また、すでに導入済みのプロジェクトでは以下の対応を行う必要があります。