Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Trie + implement UI for search suggestions #33

Closed
simongray opened this issue Mar 1, 2022 · 2 comments
Closed

Fix Trie + implement UI for search suggestions #33

simongray opened this issue Mar 1, 2022 · 2 comments
Labels
bug Something isn't working enhancement New feature or request

Comments

@simongray
Copy link
Member

Perhaps the easy fix is to separate frontend code into a shadow-cljs.edn file, although I am unsure whether this will be possible since shadow-cljs does depend on some backend libs too.

Other resources:
@simongray simongray added bug Something isn't working enhancement New feature or request labels Mar 30, 2022
@simongray
Copy link
Member Author

It has both been fixed in version 0.3 and I moved the frontend dependencies to shadow-cljs.edn in the meantime, so now everything works as before.

simongray added a commit that referenced this issue Oct 26, 2022
@simongray
#33 - reinstated old autocomplete code
a09cafd 
- the trie library has been fixed
- there was no issue now anyway, since the frontend uses shadow-cljs.edn
@simongray
Copy link
Member Author

Since it doesn't need to be in shadow-cljs.edn anymore and since I needed to use features of deps.edn (local and git deps), frontend deps have all been moved back to deps.edn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@simongray