Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mskim revision #3

Closed
1 task done
ws-choi opened this issue Jul 3, 2021 · 3 comments · Fixed by #5
Closed
1 task done

mskim revision #3

ws-choi opened this issue Jul 3, 2021 · 3 comments · Fixed by #5
Assignees
@rlaalstjr47
Labels
question Further information is requested
Projects
KUIELAB's MDX-Net

Comments

@ws-choi
Copy link
Collaborator

ws-choi commented Jul 3, 2021 •
edited by rlaalstjr47

  • please check the below class is designed correctly.

mdx-net/src/models/mdxnet.py

Line 128 in b9eb84d

class ConvTDFNet(AbstractMDXNet):

@ws-choi ws-choi added the question Further information is requested label Jul 3, 2021
@ws-choi ws-choi added this to To do in KUIELAB's MDX-Net via automation Jul 3, 2021
@rlaalstjr47
Copy link
Contributor

remove parameters mid_tdf and t_scale

@ws-choi
Copy link
Collaborator Author

ws-choi commented Jul 4, 2021

check val every n epoch => 100

@rlaalstjr47
Copy link
Contributor

data.zip

@ws-choi ws-choi linked a pull request Jul 5, 2021 that will close this issue
validation logic for both ddp and single server #5
Merged
@ws-choi ws-choi closed this as completed in #5 Jul 5, 2021
KUIELAB's MDX-Net automation moved this from To do to Done Jul 5, 2021
@ws-choi ws-choi mentioned this issue Jul 5, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rlaalstjr47 rlaalstjr47

Labels
question Further information is requested
Projects
No open projects
KUIELAB's MDX-Net
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

validation logic for both ddp and single server kuielab/mdx-net
2 participants
@ws-choi @rlaalstjr47