Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 3.1.3 is not es5 compatible because of lru-cache 5.1.1 #74

Open
ayal opened this issue May 31, 2020 · 3 comments
Open

version 3.1.3 is not es5 compatible because of lru-cache 5.1.1 #74

ayal opened this issue May 31, 2020 · 3 comments

Comments

@ayal
Copy link

ayal commented May 31, 2020

version 3.1.3 bumped to lru-cache@5.1.1 which is not es5 compatible

2b63345

It might even be that lru-cache is purely meant for node:
2b63345

If that’s the case, I propose locking an older version of lru-cache until something more future-proof is done in this regard.

I can push a PR, temporarily locking in the most recent version of lru-cache that worked as expected in ES5 environments.

@ayal ayal changed the title version 3.1.3 is not es5 compatible because of lru-cache version 3.1.3 is not es5 compatible because of lru-cache 5.1.1 May 31, 2020
@kuitos
Copy link
Owner

kuitos commented Jun 1, 2020

We made this change via #72

BTW which way u used with axios-extensions?
image

If you used it with a script tag, we may need to change the rollup config to transpile it to compatible with es5.

If u used it with a npm way, I think u should make your babel to compile the node_modules and make your dependencies compatible with es5 after bundler build.

@ayal
Copy link
Author

ayal commented Jun 2, 2020

I use the package with npm.

Of course I can transpile lru-cache myself but I was under the impression that it's bad practice to transpile node_modules + deps, and that the consumer of client-side packages should assume / expect that they are already transpiled and es5 compatible (including their deps).

This was true for axios-extensions until version 3.1.3 and bumping lru-cache version broke this.

@krychu90
Copy link

+1
I had to downgrade to 3.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants