Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting working directory in install_on_local.sh #12

Closed
phusen opened this issue Nov 3, 2021 · 1 comment
Closed

Setting working directory in install_on_local.sh #12

phusen opened this issue Nov 3, 2021 · 1 comment

Comments

@phusen
Copy link

phusen commented Nov 3, 2021

The script install_on_local.sh sets the variable work_path to $(PWD). In bash, this tries to run the command PWD, which usually doesn't exist. I believe, it should be $PWD, ${PWD} or $(pwd).

work_path=$(PWD)

Also, ideally, some quotes should probably be added to support people running this in paths with spaces, eg:

# work_path=/path/to/alphafold-code
work_path="$PWD"
# update openmm 
a="$(which python)"
cd "$(dirname "$(dirname "$a")")/lib/python3.8/site-packages"
patch -p0 < "$work_path/docker/openmm.patch"
@kuixu
Copy link
Owner

kuixu commented Nov 17, 2021

Approved. Thanks for your contribution.

@kuixu kuixu closed this as completed Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants