Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failure to install lxml breaks build on gh actions #184

Closed
kkappler opened this issue Dec 29, 2023 · 5 comments
Closed

Failure to install lxml breaks build on gh actions #184

kkappler opened this issue Dec 29, 2023 · 5 comments

Comments

@kkappler
Copy link
Collaborator

See aurora issue # 313

It looks like something has updated with lxml and python 3.8 & 3.9 are not able to build our environment.

Here is a gh actions test that failed Dec 29
But the same test passed around a week ago.

@kkappler
Copy link
Collaborator Author

@kujaku11 can you please add https://github.com/laura-iris to mt_metadata with push permission in order to test branch fix_issue_184?

@laura-iris
Copy link

lxml is being installed through obspy and isn't pinned to a specific version there. Today lxml released version 5.0.0, which explains the change in behavior today. I haven't had time to look much further than that, but I'll get back to it next week.

@laura-iris
Copy link

@kkappler I don't have the permissions to restart the 3.8 pipeline in mt_metadata, but I do see that you have one in aurora that passed about an hour ago. It looks like it handled lxml v5.0.0 just fine in that case: https://github.com/simpeg/aurora/actions/runs/7402625504/job/20140872929

Makes me wonder if it was an issue with the new release that has since been dealt with?

@kujaku11
Copy link
Owner

kujaku11 commented Jan 4, 2024

@laura-iris I just added you as a collaborator.

@kujaku11
Copy link
Owner

kujaku11 commented Jan 4, 2024

@kkappler @laura-iris Looks like the issue was fixed, all tests pass now. Gonna close this issue for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants