Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support jennifer ImportName, ImportAlias #7

Open
MrEhbr opened this issue Mar 13, 2018 · 1 comment
Open

Support jennifer ImportName, ImportAlias #7

MrEhbr opened this issue Mar 13, 2018 · 1 comment

Comments

@MrEhbr
Copy link

MrEhbr commented Mar 13, 2018

There are new mechanism to add alias in https://github.com/dave/jennifer
It will be great if Gokit-cli will not generate code like

package http

import (
        context "context"
        json "encoding/json"
        errors "errors"
        endpoint "github.com/User/project/pkg/endpoint"
        http1 "github.com/go-kit/kit/transport/http"
        http "net/http"
)

If you have thoughts how to do that i could help

@kujtimiihoxha
Copy link
Owner

Hey there

I did not have the time to look at kit for a while, I have nothing against using the new features of jennifer but I don't think I will have time to implement it in the near future.

Thanks for the suggestion and I would be glad to review and merge any PR related to this proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants