Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show warning notification when NACKs happen on global #2153

Open
kleinfreund opened this issue Feb 7, 2024 · 2 comments
Open

Show warning notification when NACKs happen on global #2153

kleinfreund opened this issue Feb 7, 2024 · 2 comments
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@kleinfreund
Copy link
Contributor

Description

(Someone to add more details here)

@kleinfreund kleinfreund added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature kind/service-review Service review issue labels Feb 7, 2024
@jakubdyszkiewicz
Copy link
Contributor

What I can imagine is that if we see any rejection https://github.com/kumahq/kuma/blob/master/api/system/v1alpha1/zone_insight.proto#L107
We show "⚠️" on list of zones or in list of connections which would say something like "Zone CP rejected the configuration, check Zone CP logs for details".

The only problem now is that we could trigger this with the initial KDS connection where Mesh is synced with policies. Because of lack of KDS order Zone CP can receive policies before mesh and NACKs them.

We could consider adding something like "last_rejection_timestamp" so if NACK is "one of" the warning in the GUI would go away.

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting kind/service-review Service review issue labels Feb 12, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label May 13, 2024
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants