Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display MeshHTTPRoute (tcp route probably as well) tags in outbound view #2412

Open
slonka opened this issue Apr 9, 2024 · 1 comment
Open
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@slonka
Copy link
Contributor

slonka commented Apr 9, 2024

Description

The below explanation assumes the following MeshHTTPRoute:

apiVersion: kuma.io/v1alpha1
kind: MeshHTTPRoute
metadata:
 name: http-route-1
 namespace: kuma-system
 labels:
   kuma.io/mesh: default
spec:
 targetRef:
   kind: MeshService
   name: frontend_kuma-demo_svc_8080
 to:
   - targetRef:
       kind: MeshService
       name: backend_kuma-demo_svc_3001
     rules:
       - matches:
           - path:
               type: Prefix
               value: /
         default:
           backendRefs:
             - kind: MeshServiceSubset
               name: backend_kuma-demo_svc_3001
               tags:
                 version: "v0"
               weight: 90
             - kind: MeshServiceSubset
               name: backend_kuma-demo_svc_3001
               tags:
                 version: "v1"
               weight: 10

After merging kumahq/kuma#9768 stats for different splits won't get merged so you can view them in Grafana.

image

The problem is that there is no easy way to figure out which "Destination service" maps to which split. The hash does not tell us much. If a person copies a hash they can see that it matches one of the outbounds.

image

But they still don't know what's the difference between them.


What I suggest is to add the tags used for the split (v0, v1 in this case) and put them next to the service tag:

image

@slonka slonka added triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Apr 9, 2024
@slonka
Copy link
Contributor Author

slonka commented Apr 10, 2024

For now a user can click on the outbound:

image

click on clusters and associate pod ip with cluster ip:

image

image

@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

2 participants