Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove configuration optionEnableLocalhostInboundClusters from control-plane #4772

Closed
lukidzi opened this issue Aug 5, 2022 · 3 comments · Fixed by #6214
Closed

Remove configuration optionEnableLocalhostInboundClusters from control-plane #4772

lukidzi opened this issue Aug 5, 2022 · 3 comments · Fixed by #6214
Assignees
@bartsmykla
Labels
breaking-change kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Aug 5, 2022

Description

In a #4630 we are introducing a configuration option that allows us to turn off new behavior. We want to make it a default behavior, so in the future, we need to remove EnableLocalhostInboundClusters configuration option.
@lukidzi lukidzi added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Aug 5, 2022
@michaelbeaumont michaelbeaumont mentioned this issue Aug 5, 2022
Merged
9 tasks
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it kind/cleanup Cleanup/refactor an existing component/code breaking-change and removed triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Aug 8, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@lukidzi lukidzi removed the triage/stale Inactive for some time. It will be triaged again label Nov 7, 2022
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Feb 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Feb 6, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting and removed triage/stale Inactive for some time. It will be triaged again labels Feb 27, 2023
@jakubdyszkiewicz jakubdyszkiewicz removed the triage/pending This issue will be looked at on the next triage meeting label Feb 27, 2023
@bartsmykla bartsmykla mentioned this issue Mar 7, 2023
Merged
6 tasks
@bartsmykla
Copy link
Contributor

Reopening as we had to revert change till #5335 is fixed (Envoy 1.25)

@bartsmykla bartsmykla reopened this Mar 7, 2023
@michaelbeaumont michaelbeaumont mentioned this issue Mar 30, 2023
Merged
6 tasks
@lobkovilya lobkovilya mentioned this issue Apr 3, 2023
Merged
6 tasks
@lahabana lahabana closed this as completed Apr 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bartsmykla bartsmykla

Labels
breaking-change kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(dp/cp/config): remove EnableLocalhostInboundClusters option bartsmykla/kuma
5 participants
@lahabana @michaelbeaumont @jakubdyszkiewicz @bartsmykla @lukidzi