Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove vendored code from go-control-plane #4926

Open
michaelbeaumont opened this issue Aug 29, 2022 · 6 comments
Open

Remove vendored code from go-control-plane #4926

michaelbeaumont opened this issue Aug 29, 2022 · 6 comments
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.9.x

Comments

@michaelbeaumont
Copy link
Contributor

What happened?

We vendored some code from go-control-plane for using non-Envoy resources and we depend on concrete upstream structs instead of new interfaces. It will likely require some upstream changes to remove this code. See #2719 and #4877 (comment) for more context.
@michaelbeaumont michaelbeaumont added triage/pending This issue will be looked at on the next triage meeting kind/cleanup Cleanup/refactor an existing component/code labels Aug 29, 2022
@michaelbeaumont michaelbeaumont changed the title Remove code duplicated from go-control-plane Remove code duplicated from go-control-plane Aug 29, 2022
@michaelbeaumont michaelbeaumont changed the title Remove code duplicated from go-control-plane Remove vendored code from go-control-plane Aug 29, 2022
@michaelbeaumont michaelbeaumont mentioned this issue Aug 29, 2022
Merged
12 tasks
@jakubdyszkiewicz jakubdyszkiewicz added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Aug 29, 2022
@github-actions
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Nov 28, 2022
@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Dec 5, 2022
@michaelbeaumont michaelbeaumont mentioned this issue Mar 1, 2023
Merged
6 tasks
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Mar 6, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@slonka slonka removed the triage/stale Inactive for some time. It will be triaged again label Mar 6, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Jun 5, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Jun 5, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Sep 4, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Sep 4, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Sep 6, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Dec 6, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Dec 6, 2023
@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 6, 2024

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@michaelbeaumont michaelbeaumont removed the triage/stale Inactive for some time. It will be triaged again label Mar 6, 2024
@lahabana lahabana added this to the 2.8.x milestone Apr 5, 2024
@lahabana lahabana modified the milestones: 2.8.x, 2.9.x Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/cleanup Cleanup/refactor an existing component/code triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.9.x
Development

No branches or pull requests
4 participants
@lahabana @michaelbeaumont @slonka @jakubdyszkiewicz