Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage appProtocol from K8S 1.18+ #761

Closed
jakubdyszkiewicz opened this issue May 22, 2020 · 4 comments · Fixed by #1413
Closed

Leverage appProtocol from K8S 1.18+ #761

jakubdyszkiewicz opened this issue May 22, 2020 · 4 comments · Fixed by #1413
Labels
good first issue Good for newcomers

Comments

@jakubdyszkiewicz
Copy link
Contributor

Summary

Kubernetes 1.18 introduced appProtocol field in Service. We can use it for choosing protocol instead of placing annotations.
https://kuma.io/docs/0.5.0/policies/http-support-in-kuma/

@tharun208
Copy link
Contributor

tharun208 commented Jan 12, 2021

ok, appProtocol has been available for ga from Nov 2020. @jakubdyszkiewicz I have a doubt, do we need to support backward compatibility for this, I don't think so because the change will be on the policy and the user can re-configure it, once it is released.

@jakubdyszkiewicz
Copy link
Contributor Author

Yes, we need to support also annotations. It will take a long time to support only K8S 1.18+

@tharun208
Copy link
Contributor

so, once this pr is merged, deprecating annotations support is introduced as a separate pr or any other approach like introducing feature toggles?

@lobkovilya
Copy link
Contributor

Hey @tharun208! I think we should give support for both ways of providing the protocol, and it makes more sense to me to do so in a single pr.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants