Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Entire Directory using kumactl #8491

Open
doctorwu opened this issue Nov 29, 2023 · 5 comments
Open

Apply Entire Directory using kumactl #8491

doctorwu opened this issue Nov 29, 2023 · 5 comments
Assignees
Labels
good first issue Good for newcomers kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@doctorwu
Copy link

doctorwu commented Nov 29, 2023

Description

It would be a useful feature to have the ability to apply all files inside a directory, without having to use fancy shell commands, i.e. xargs, like you can with kubectl.

For example:

kumactl apply -f some-dir/
@doctorwu doctorwu added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting labels Nov 29, 2023
@jakubdyszkiewicz jakubdyszkiewicz added good first issue Good for newcomers triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Dec 4, 2023
@lplazas
Copy link
Contributor

lplazas commented Dec 5, 2023

Happy to pick this up @jakubdyszkiewicz

@lplazas
Copy link
Contributor

lplazas commented Dec 22, 2023

Hey all, I have a first pass implementation ready, but I’d appreciate some thoughts around this:
Should we restrict the files we apply to be .yaml or .yml (as I currently do here in the link below)? or should we try to apply every file and ignore if it isn't yaml?

https://github.com/kumahq/kuma/pull/8647/files#diff-1fe08e69b5b0c09a1604645df446a74ccf5123e8f7dd942520155640af802a7eR177

@michaelbeaumont
Copy link
Contributor

@lplazas I'd say we should have the same behavior as kubectl here.

@lplazas
Copy link
Contributor

lplazas commented Dec 22, 2023

@lplazas I'd say we should have the same behavior as kubectl here.

I just checked and if a single file is passed to kubectl apply it will read it and try to parse it regardless of the extension. If kubectl apply receives a dir, it will only pick up the files with yaml extension.

@github-actions github-actions bot added the triage/stale Inactive for some time. It will be triaged again label Mar 22, 2024
Copy link
Contributor

This issue was inactive for 90 days. It will be reviewed in the next triage meeting and might be closed.
If you think this issue is still relevant, please comment on it or attend the next triage meeting.

@jakubdyszkiewicz jakubdyszkiewicz removed the triage/stale Inactive for some time. It will be triaged again label Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

4 participants