feat: enforce strong typing for Tags #52
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why: Although the current typescript setup enforced that the tags be strings, it didn't ensure that the tags added to a resource are actually defined in the
tags.ts
. This is why many tags used in resources were not actually coming up on the filter component. While reviewing a PR it could be overlooked due to a human error but having it strongly typed will avoid it all together in the build step itself.