feat: Add filter by ecosystem #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I tried to add ecosystem filter looking into PR with manifest filter - FYI |
kunalnagar
approved these changes
May 26, 2024
There was a problem hiding this comment.
@romkaspb - thanks for the contribution! It looks great 🚀
- Do you mind posting some sample results as screenshots in the comment before you merge the PR?
- Do you mind updating the PR title to remove the
WIPbefore you merge?
|
Hey @kunalnagar,
|
I think let's keep the existing text as I see this getting longer as more fields are added. This gave me an idea for a feature -- customize what columns/fields should be shown in the alert that gets sent out. Ecosystem could be one of those fields.
Thanks. You can go ahead and merge. |
romkaspb
changed the title
|
@kunalnagar did squash and changed PR title. I don't have permissions to merge PR. |
github-actions bot
pushed a commit
that referenced
this pull request
May 27, 2024
[skip ci] ## [1.13.0](v1.12.36...v1.13.0) (2024-05-27) ### Features * Add filter by ecosystem ([#184](#184)) ([41d6d72](41d6d72))
|
🎉 This PR is included in version 1.13.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Good day @kunalnagar,
thank you for your work.
While in our project we have monorepository, we need the feature to run action for different ecosystems.
I made some changes and it works like a charm.
I know that it's not ready-to-merge PR, but maybe we can prepare it together? I'm not a JS developer btw :)