Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken dependencies - blobs/__init__.py #14

Closed
jisungk opened this issue Mar 7, 2017 · 1 comment
Closed

Broken dependencies - blobs/__init__.py #14

jisungk opened this issue Mar 7, 2017 · 1 comment

Comments

@jisungk
Copy link
Contributor

jisungk commented Mar 7, 2017

In the master branch, blobs/__init__.py tries to import blobs.maxout and blobs.rnn modules which do not currently exist (they did in previous commits). This causes import errors.

I'm not sure if the blobs.maxout and blobs.rnn modules have become redundant, but deleting the import statements in blobs/__init__.py allows the MNIST example to run without import errors.

See https://github.com/kundajelab/deeplift/blob/master/deeplift/blobs/__init__.py

@jisungk jisungk changed the title Broken dependencies Broken dependencies - blobs/__init__.py Mar 7, 2017
@AvantiShri
Copy link
Collaborator

Thanks for catching this; those modules exist on a private dev branch and the import statements + cached modules lingered when I merged into the private branch. I will set up continuous integration eventually to avoid introducing this in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants