Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Astronaut_runner #3343

Merged
merged 13 commits into from
May 24, 2024
Merged

Astronaut_runner #3343

merged 13 commits into from
May 24, 2024

Conversation

tanishkaa08
Copy link
Contributor

@tanishkaa08 tanishkaa08 commented May 16, 2024

PR Description 📜

Created a new game called Astroaut runner.
Fixes #3331


Mark the task you have completed ✅

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.

  • I have performed a self-review of my own code or work.

  • I have commented my code, particularly in hard-to-understand areas.

  • My changes generates no new warnings.

  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE

  • I have added screenshot for website preview in assets/images

  • I have added entries for my game in main README.md

  • I have added README.md in my folder

  • I have specified the respective issue number for which I have requested the new game.




Thank you soo much for contributing to our repository 💗

IT is a fun game built using html css and javascript . The astronaut is supposed to dodge the obstacle in order to score points.
@kunjgit
Copy link
Owner

kunjgit commented May 16, 2024

Thank you @tanishkaa08 ,for creating the PR and contributing to our GameZone 💗
Review team will review the PR and will reach out to you soon! 😇
Make sure that you have marked all the tasks that you are done with ✅.
Thank you for your patience! 😀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tanishkaa08,
You need to make the following changes:

  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tanishkaa08 in root assets/images don't add all assets you want in your game just screen shot of you game should be there !
if you need more images add it in your directory!

@tanishkaa08 tanishkaa08 requested a review from kunjgit May 20, 2024 14:01
@kunjgit
Copy link
Owner

kunjgit commented May 22, 2024

@tanishkaa08 resolve the merge conflicts !

@kunjgit
Copy link
Owner

kunjgit commented May 23, 2024

Thank you @tanishkaa08 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

Copy link
Owner

@kunjgit kunjgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @tanishkaa08,
You need to make the following changes:

  • Please create a new folder inside the "Games" folder.
  • Please add a README.md file inside the newly created folder.
  • Please modify the main README.md file.
  • Please add an image to the assets/images directory.

Hoping that you will make those changes soon 🚀

@kunjgit kunjgit added the Changes Requested ⚒️ Changes have to be done label May 23, 2024
@tanishkaa08 tanishkaa08 reopened this May 23, 2024
@tanishkaa08 tanishkaa08 requested a review from kunjgit May 23, 2024 20:15
@tanishkaa08
Copy link
Contributor Author

please review it.

@kunjgit kunjgit merged commit 84a6f1e into kunjgit:main May 24, 2024
1 check passed
@kunjgit
Copy link
Owner

kunjgit commented May 24, 2024

Thank you @tanishkaa08 , for your valuable time and contribution in our GameZone 💗.
It’s our GameZone, so Let’s build this GameZone altogether !!🤝
Hoping to see you soon with another PR again 😇
Wishing you all the best for your journey into Open Source🚀

@kunjgit kunjgit added level3 Adding new features gssoc GSSoC24 program label and removed Pending ⏱️ Changes Requested ⚒️ Changes have to be done labels May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC24 program label level3 Adding new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: astronaut runner
2 participants