Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD Rock-paper-scissor #4675

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

kartikmehta18
Copy link

@kartikmehta18 kartikmehta18 commented Jun 22, 2024

PR Description πŸ“œ

Rock-Paper-Scissors, is a simple hand game usually played between two people. Each player simultaneously forms one of three shapes with an outstretched hand. The possible outcomes are: Rock crushes Scissors, Scissors cuts Paper,Paper covers Rock
Fixes #4672


Mark the task you have completed βœ…

  • I follow CONTRIBUTING GUIDELINE & CODE OF CONDUCT of this project.
  • I have performed a self-review of my own code or work.
  • I have commented my code, particularly in hard-to-understand areas.
  • My changes generates no new warnings.
  • I have followed proper naming convention showed in CONTRIBUTING GUIDELINE
  • I have added screenshot for website preview in assets/images
  • I have added entries for my game in main README.md
  • I have added README.md in my folder
  • I have added working video of the game in README.md (optional)
  • I have specified the respective issue number for which I have requested the new game.

Add your screenshots(Optional) πŸ“Έ

image



Thank you soo much for contributing to our repository πŸ’—

@kunjgit
Copy link
Owner

kunjgit commented Jun 22, 2024

Thank you @kartikmehta18 ,for creating the PR and contributing to our GameZone πŸ’—
Review team will review the PR and will reach out to you soon! πŸ˜‡
Make sure that you have marked all the tasks that you are done with βœ….
Thank you for your patience! πŸ˜€

@kartikmehta18
Copy link
Author

plz review this @kunjgit

Copy link
Collaborator

@ishita-43 ishita-43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make following changes
add your game entry into main readme.md file of the gamezone repo
add your game image into asset folder of the gamezone follow guidelines while naming the image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[New game]: Add Rock, Papper, Scissor game
3 participants