Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If the bundle is disabled (ie: enabled: false), don't validate the dsn parameter #13

Closed
j0k3r opened this issue Oct 29, 2013 · 0 comments

Comments

@j0k3r
Copy link

j0k3r commented Oct 29, 2013

In recents commit, you introduced the enabled (and/or the dsn) option.
But if we don't enable the plugin, it still wants to validate the dsn parameter.

The path "kunstmaan_sentry.dsn" cannot contain an empty value, but got null.

If we set :

kunstmaan_sentry:
    enabled: false

You shouldn't try to validate other parameters since it is not enabled.
Or at least, you should allow :

kunstmaan_sentry:
    enabled: false
    dsn: null

Or

kunstmaan_sentry:
    enabled: false
    dsn: ''
wimvds pushed a commit that referenced this issue Nov 6, 2013
@jockri jockri closed this as completed Dec 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants