Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove storage driver interface break point #88

Closed
dozer-jang opened this issue Jun 20, 2023 · 1 comment · Fixed by #89
Closed

remove storage driver interface break point #88

dozer-jang opened this issue Jun 20, 2023 · 1 comment · Fixed by #89
Assignees
Labels
bug Something isn't working

Comments

@dozer-jang
Copy link
Contributor

Describe the bug
fileservice 패키지 코드들 중 driver 인터페이스를 이용하지 않고 파일을 핸들링 하는 경우가 존재합니다.
로그 저장소의 변경을 위해서 모든 파일 핸들링은 driver 인터페이스를 통해서 이루어져야 합니다.

os 패키지의 함수로 직접 파일을 핸들링하고 있습니다.

err := os.Remove(file)

err = os.MkdirAll(cfg.LogDataPath(), 0755)

files, err := os.ReadDir(logDir.Fullpath)

To Reproduce

Expected behavior
-driver 인터페이스를 이용하여 구현, 필요시 인터페이스 확장

Screenshots

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context

@dozer-jang dozer-jang added the bug Something isn't working label Jun 20, 2023
@dozer-jang dozer-jang self-assigned this Jun 20, 2023
@dozer-jang
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant