Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL format for pc-regions #4

Closed
kuper-adrian opened this issue Oct 5, 2018 · 3 comments
Closed

Wrong URL format for pc-regions #4

kuper-adrian opened this issue Oct 5, 2018 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest

Comments

@kuper-adrian
Copy link
Owner

PUBG API v6.0.0 released October 3rd and changed the URL format for getting the season stats of any given player.

Old format:

https://api.pubg.com/shards/pc-{region}/players/{accountId}/seasons/{seasonId}

New format:

https://api.pubg.com/shards/{steam or kakao}/players/{accountId}/seasons/{seasonId}

More info on api v6.0.0 here.

Since pubg-royale still uses the old format, it only returns empty gameModeStats objects at the moment 😞 To fix this the playerStats() function must be adjusted to the new url format for every PC region (the XBOX regions still use the old format!).

Since its Hacktoberfest I will leave this issue up for grabs for some time for anyone interested in earning another pull request towards his awesome t-shirt 😉

This would also fix issue kuper-adrian/statg-bot#12 of the statg-discord-bot.

@alizhdanov
Copy link
Contributor

Hey, how do you know whether it's steam or kakao? :-)

@kuper-adrian
Copy link
Owner Author

Good question 😅 Well at least the pc-kakao region should use kakao instead of steam but I don't really know if any of the other seasons do, sorry. I think it would be fine if only pc-kakao uses kakao for now. If other regions also need to use kakao, it could be fixed later.

@alizhdanov
Copy link
Contributor

Ok, I'll do it then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants