make gen-check failed

[gy95]

What happened:
make gen-check failed

# make gen-check 
go mod tidy -compat=1.17
go clean -testcache
go clean -cache
rm -rf out/linux-amd64
rm -rf out/prom
go install -a github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb@latest
go install -a github.com/brancz/gojsontoyaml@latest
go install -a github.com/google/go-jsonnet/cmd/jsonnet@latest
rm -rf manifests/profiles/prom/
mkdir -p manifests/profiles/prom/
mkdir -p out/prom
cp manifests/jsonnet/kube-prometheus.jsonnet out/prom
hack/gen-prom.sh out/prom v0.10.0 kube-prometheus.jsonnet
begin to generate prom manifests
path: out/prom
version: v0.10.0
jsonnet file: kube-prometheus.jsonnet
~/go/src/github.com/kurator-dev/kurator/out/prom ~/go/src/github.com/kurator-dev/kurator
hack/gen-prom.sh: line 13: jb: command not found
Makefile:65: recipe for target 'gen-prom' failed
make: *** [gen-prom] Error 127

Solutions:
we should export PATH=$PATH:$GOPATH/bin after we install jb

kurator/Makefile

Lines 57 to 61 in 33fef92

	.PHONY: install-tools
	install-tools:
	go install -a github.com/jsonnet-bundler/jsonnet-bundler/cmd/jb@latest
	go install -a github.com/brancz/gojsontoyaml@latest
	go install -a github.com/google/go-jsonnet/cmd/jsonnet@latest

or we can use the function defined in util.sh

kurator/hack/util.sh

Lines 13 to 20 in 33fef92

	function util::install_tools() {
	local package="$1"
	local version="$2"
	echo "go install ${package}@${version}"
	GO111MODULE=on go install "${package}"@"${version}"
	GOPATH=$(go env GOPATH | awk -F ':' '{print $1}')
	export PATH=$PATH:$GOPATH/bin
	}

but i don't know how to run functions of shell script in Makefile

What you expected to happen:

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

• Kurator version:
• Others:

[hzxuzhonghu]

good catch @gy95

we donot need to expose install-tools, which is now used by gen-prom

I am thinking we can move the install into hack/gen-prom.sh

[gy95]

That's a good way.