Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Application] fleet being unique but can be set in multiple places. #316

Closed
Xieql opened this issue Jun 5, 2023 · 3 comments
Closed

[Application] fleet being unique but can be set in multiple places. #316

Xieql opened this issue Jun 5, 2023 · 3 comments
Assignees
@Xieql
Labels
kind/feature

Comments

@Xieql
Copy link
Contributor

Xieql commented Jun 5, 2023

What would you like to be added:

Application API update

Why is this needed:

There are some unreasonable aspects in the current API, such as the fleet being unique but may need to be set in multiple places.
@Xieql Xieql changed the title [application] Application API update [Application] Application API update Jun 5, 2023
@Xieql
Copy link
Contributor Author

Xieql commented Jun 29, 2023

Inspired by previous work, I have an idea: we can keep the existing API unchanged，
and use webhooks to ensure that users configure all fleets uniquely and allow for setting default values.

@Xieql Xieql changed the title [Application] Application API update [Application] fleet being unique but can be set in multiple places. Jun 29, 2023
@Xieql
Copy link
Contributor Author

Xieql commented Jun 29, 2023

/assign

@Xieql Xieql mentioned this issue Jul 10, 2023
Merged
@Xieql
Copy link
Contributor Author

Xieql commented Jul 25, 2023

fix by webhook #359

@Xieql Xieql closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Xieql Xieql

Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Xieql