Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

using peerDependencies over dependencies in package.json #38

Closed
alinz opened this issue Jun 9, 2015 · 3 comments
Closed

using peerDependencies over dependencies in package.json #38

alinz opened this issue Jun 9, 2015 · 3 comments

Comments

@alinz
Copy link
Contributor

alinz commented Jun 9, 2015

I think we should start using peerDependencies instead of dependencies for referring to react-native.

I will provide PR in case you want to support this.
@alinz alinz mentioned this issue Jun 9, 2015
Merged
@Kureev
Copy link
Owner

Kureev commented Jun 9, 2015

You decided to move it to peerDependencies in all repos, right? 😉

@Kureev Kureev closed this as completed in 0d4715e Jun 9, 2015
Kureev pushed a commit that referenced this issue Jun 9, 2015
Merge pull request #39 from alinz/feature/#38
1568ebe 
fixed #38 replaced dependencies with peerDependencies in package.json
@alinz
Copy link
Contributor Author

alinz commented Jun 9, 2015

@Kureev I wanted to make cleaner :P I'm using it inside my app and I ended up doing a lot of dependencies changes. So I decided to go over all my dependencies and made them peer. :P

@Kureev
Copy link
Owner

Kureev commented Jun 9, 2015

hehe, anyway good work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alinz @Kureev