Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CHART.JS v4 compatibility #165

Closed
wants to merge 8 commits into from
Closed

Conversation

stockiNail
Copy link
Collaborator

@stockiNail stockiNail commented Nov 17, 2022

Fix #164

  • solve a couple of TS types issues.
  • chartjs-adapter-date-fns not compatible with CHART-JS 4 yet.
  • chart-plugin-datalabels not compatible with CHART-JS 4 yet

@stockiNail stockiNail added the bug Something isn't working label Nov 17, 2022
@stockiNail stockiNail added this to the 2.2.0 milestone Nov 17, 2022
@stockiNail
Copy link
Collaborator Author

@kurkle I'm going on tomorrow. About requireVersion function, it didn't work with version 4.0.1. I have copied the implementation of annotation plugin, so they are aligned.

@kurkle
Copy link
Owner

kurkle commented Nov 18, 2022

I think it only needs updated date-fns adapter and should be fine.

@stockiNail
Copy link
Collaborator Author

I have an issue importing color functions from the helpers of Chartjs in the types test. I wrote it in slack.
Sounds an issue of version 4 but not sure

@stockiNail
Copy link
Collaborator Author

I think it only needs updated date-fns adapter and should be fine.

having a look to the error, it seems more related to datalabels. Date-fns adapter version updated to 2.0.1.

@stockiNail
Copy link
Collaborator Author

I have an issue importing color functions from the helpers of Chartjs in the types test. I wrote it in slack.
Sounds an issue of version 4 but not sure

I have changed tsconfig and now it's working

@stockiNail
Copy link
Collaborator Author

@kurkle do you know why date-fns is needed? I don't see any place where it's used (if I'm not wrong)

types/tests/tsconfig.json Outdated Show resolved Hide resolved
@kurkle kurkle added enhancement New feature or request and removed bug Something isn't working labels Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrading Chart.JS to version 4.x, treemap throws error
2 participants