Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support missing/partial groups in the data #45

Open
dej611 opened this issue Oct 4, 2021 · 6 comments
Open

FR: Support missing/partial groups in the data #45

dej611 opened this issue Oct 4, 2021 · 6 comments
Labels
enhancement New feature or request
Milestone

Comments

@dej611
Copy link

dej611 commented Oct 4, 2021

Hi 馃憢

I'm using this library to visualize a coverage map for a project.
I'm mapping path folders to groups in order to have a hierarchical map, but folder nesting is not uniform, resulting in a weird result in the final map.
I've tried already to set thee missing group properties to '' or undefined but results were not as expected - lots of duplication.

It would be nice to natively support this kind of hierarchical grouping, or having a flag to enable it.

Example data:

[
  {
    folder: './src',
    component: null,
    subFolder: null,
    file: 'index.js'
  },
  {
    folder: './src',
    component: 'A',
    subFolder: null,
    file: 'A.js'
  }
  ...
]
@dej611 dej611 changed the title FR: Support missing partial groups in the data FR: Support missing/partial groups in the data Oct 4, 2021
@kurkle
Copy link
Owner

kurkle commented Oct 4, 2021

Can you create a fiddle reproducing the issue?

@dej611
Copy link
Author

dej611 commented Oct 5, 2021

馃う the main problem I had was a typo in a group name. I noticed when creating the fiddle.

Anyway, this is a fiddle to reproduce the kind of visualization I'm trying to build: https://codesandbox.io/s/snowy-glade-bzg1t?file=/src/index.js

The data structure was the one I had and that would be nice to support (IMHO), but I think the workaround used in dataOffset can be ok.

Another nice feature, which probably can be tracked in another issue, is the possibility to express rect sizes with another property.

@kurkle
Copy link
Owner

kurkle commented Oct 6, 2021

Another nice feature, which probably can be tracked in another issue, is the possibility to express rect sizes with another property.

Not sure I follow, opposed to color?

@dej611
Copy link
Author

dej611 commented Oct 8, 2021

No.
For instance, using the US states demo: area dimension property used for rect surface and the population property used as color

@kurkle
Copy link
Owner

kurkle commented Oct 8, 2021

Oh right, so that would need to be summed up too. Can you open another issue for that?

@kurkle kurkle added this to the v2.0 milestone Oct 28, 2021
@kurkle kurkle added the enhancement New feature or request label Oct 28, 2021
@kurkle kurkle modified the milestones: 2.0.0, 2.1.0 Nov 23, 2021
@kurkle kurkle modified the milestones: 2.1.0, 2.2.0 Oct 12, 2022
@kurkle kurkle modified the milestones: 2.2.0, 2.3.0 Nov 22, 2022
@kurkle
Copy link
Owner

kurkle commented Jan 24, 2023

Still delaying this one to get other things out.

@kurkle kurkle modified the milestones: 2.3.0, 2.4.0 Jan 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants