New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove imported CHART.JS parts from distribution file #18
Conversation
@kurkle not clear how to exclude @kurkle/color. Whatever import I set sounds wrong. :( |
I think importing |
No I didn't but it works!!! ur awesome! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Only doubt is if it works with chart.js v2, I don't remember if it has a compatible export. |
Ok, I'll test it against version 2.9.4 before releasing the PR |
It sounds working with 2.9.4 but the issue is not the color part but in version2, the scale object doesn't have With #16, the support of CHART.JS 2.x was dropped.... |
Right, that one should be fixed then. |
absolutely yes! I'll do in this PR, ok? or do you prefer another one? For me it's the same |
Created another PR #19 for fixing |
I have created additional workload to you.... sorry, thank you for everything! |
You also fixed some major issues with this plugin, so thank you! :) |
(would have done this right away, but actions are down again, so will check back later) |
Ok, no hurry, As said, I can go ahead using my local dist file I have to develop some java classes, test them, create doc and so on therefore I need some days. Furthermore we have planned to go to next version in 1 month (otherwise now too close to the previous one) |
Fix #17
This PR excludes the CHART.JS parts from distribution file of the plugin.
It removes also the direct dependency from
@kurkle/color
, leveraging on what it's included in CHART.JS.