New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add KARMA test suite to enable testing #22
Conversation
I had a look to |
Oh, how nice! Than you! |
Did you try adding a |
ur welcome! I wanted to understand how it works ;) |
No... only in beforeEach. Let me try |
And as usual you are right! ;) Fixed! |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@kurkle I'm going to add some test cases because I'll have a couple of PR and I want to make sure do not destroy anything! |
I tweaked the CI to do coverage analysis on sonar cloud too (and removed windows runner, because I don't know how to do coverage on multiple osses and its slow etc) So, the quality gate is failing currently because test coverage is too low.. looking forward on your new test cases to fix that! :) |
I'm doing... I have added chartjs-adapter-luxon and luxon as dependencies in order to test also the time axis |
This PR is adding test suite in order to enable the tests.
The source was
chartjs-plugin-annotation
and maybe something is not "perfect".What cannot do is to register the plugin globally (try in several ways without any success) therefore in this PR the plugin has been adding in the first test case.
EDIT: the global registration was fixed putting it in
beforeAll
hook. Thanks @kurkle