Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Button Is Misaligned with CSD #25

Closed
Saroufim opened this issue Feb 7, 2018 · 3 comments
Closed

Close Button Is Misaligned with CSD #25

Saroufim opened this issue Feb 7, 2018 · 3 comments
Labels
Milestone

Comments

@Saroufim
Copy link

Saroufim commented Feb 7, 2018

The close button on Fedora 27 with Firefox 58 + CSD is misaligned with the rest of the HeaderBar.
csd-firefox-issue
This is persistent with all sizes of the CSD bar and with both light and dark themes.

@lunakurame
Copy link
Owner

There currently are 2 versions of that CSD style sheet, for FF 57 with Fedora's patch and for FF 59. I'll fix it for FF 58 too, but I need to finish merging changes from issue #21 first. Could you check if enabling the version for FF 59 works for FF 58 on Fedora? It might work, because I remember other styles for FF 57 were misaligned for both FF 58 and 59 too.

/* Enable CSD for Firefox 59 */
@import "ui/csd.css"; /**/
/* Enable CSD for Firefox 57 (Fedora only) */
/*@import "ui/fedora-csd.css"; /**/

Let me know if it works. If not, then https://github.com/smithfred/firefox-gnome-theme-3.26-layer might have some workarounds for now.

@lunakurame lunakurame added this to the Firefox 58 milestone Feb 7, 2018
@lunakurame lunakurame added the bug label Feb 7, 2018
@Saroufim
Copy link
Author

Saroufim commented Feb 7, 2018

CSD for Firefox 59 works perfectly on Fedora 27 with Firefox 58. Thank you very much. This theme is a treasure. Thanks for making it.

@lunakurame
Copy link
Owner

I'm glad I could help (and I'm sure other contributors are too :p). Just added info that FF 58 users can use FF 59 CSD styles to the userChrome.css file (commit 53e214a), so others know about it. Thanks for testing it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants