Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Errors in iterating in limestone.js #22

Open
darklow opened this issue Jan 13, 2012 · 1 comment
Open

Errors in iterating in limestone.js #22

darklow opened this issue Jan 13, 2012 · 1 comment

Comments

@darklow
Copy link

darklow commented Jan 13, 2012

Am i missing something or there are some iterating errors.
I see in some places in limestone.js following JS syntax:

for (var filter in query.filters) {
   request.push.int32(filter.attr.length);
...

I think it should be at least like this:

for (var filter in query.filters) {
   filter = query.filters[filter];
   request.push.int32(filter.attr.length);
...

Since when iterating using for(var X in arr) returns X directly as object and not key?

Probably same is in this line 301:

for (var value in filter.values) { 
   request.push.int64(0, value)
@kurokikaze
Copy link
Owner

Yes, these are errors (kind of hard to avoid when porting from PHP - some PHP foreach syntax leaks in automatically :))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants