Number of elements in the QUIRKS array does not match

[salvacam]

The number of elements in the quirks array does not match.

In the file include/chip.h is defined the constant NUM_QUIRKS with value 10
https://github.com/kurtjd/jaxe/blob/main/include/chip8.h#L32C9-L32C19

In this file is comment each elemente of array
https://github.com/kurtjd/jaxe/blob/main/include/chip8.h#L136
but only 9 is comment

I don't know if the value of NUM_QUIRKS should be 9 or 10

In the file src/main.c is defined the array quirks with 10 elements
https://github.com/kurtjd/jaxe/blob/main/src/main.c#L41
but in the src/libretro.c the array quirks with 9 elements
https://github.com/kurtjd/jaxe/blob/main/src/libretro.c#L256

This does not affect performance or generate errors, neither in the SDL version nor in Retroarch, but I think the number of array elements in the two versions should match.

[kurtjd]

Ah good catch! The correct value should be 10. I discovered the 10th quirk while running a test ROM and then implemented it, but forgot to update that comment and the libretro port.

So there are 10 quirks total (0 - 9 inclusive). The quirk missing from that comment is:

-9: Disable undefined VF after logical OR, AND, XOR (VF is set to 0 with this disabled)

If you'd like, you can update the comment and the libretro port (I'm not too familiar with the inner-workings of the port myself) and I'll gladly accept it. If not I'll definitely update the comment to avoid confusion.

Thanks for pointing it out!

[salvacam]

Without a problem, I add the comment and update the libretro port to request the PR.
When I make the PR I will comment here

[salvacam]

Here the PR
https://github.com/kurtjd/jaxe/pull/20/files

[kurtjd]

Merged, appreciate it!