Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify version switching #7

Open
dancrew32 opened this issue Oct 24, 2013 · 2 comments
Open

simplify version switching #7

dancrew32 opened this issue Oct 24, 2013 · 2 comments
Labels

Comments

@dancrew32
Copy link

First off, thanks for the module! Just have a quick suggestion for the project:

Looks like this could use some more-obvious API version switching documentation.

Didn't know url= kwarg was available until I read through https://github.com/kurttheviking/python-simple-hipchat/blob/master/hipchat/__init__.py#L7 and saw https://github.com/kurttheviking/python-simple-hipchat/blob/master/hipchat/__init__.py#L12-L13

Since there's a V2 API now, might be worth documenting hipchat.HipChat(method=.., url=..) and the constructor might be simplified by just making it hipchat.HipChat(method=..., version=2)

api difference reasoning

@kurttheviking
Copy link
Owner

@dancrew32 thank you; i wasn't aware of the v2 api until recently but putting in simple version switching seems to make the most sense

@kurttheviking
Copy link
Owner

@dancrew32 I've talked to others who are looking for a similar feature so this is something I will look into this weekend or early next week; if you happen to have a PR I'd be happy to take a look and speed things along

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants