Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code Refactor #5

Merged
merged 1 commit into from Oct 22, 2022
Merged

Code Refactor #5

merged 1 commit into from Oct 22, 2022

Conversation

kusaasira
Copy link
Owner

@kusaasira kusaasira commented Oct 21, 2022

Code Refactor

This PR aims to do something (detailed description).

Type (Feature, Fix, Config, etc)

  • Bug fix 🐞
  • New feature ✨
  • Breaking change πŸ”©
  • This change requires a documentation update πŸ“™
  • Improvement 🌠
  • Refactor πŸ”„
  • Add Test Specs 🚦

Tests

Tests description

  • Fetching Districts.
  • Fetching counties in under a district.
  • Fetching sub-counties in under a district->county.
  • Fetching parishes in under a district->countty->subcounty.
  • Fetching parishes in under a district->countty->subcounty.
  • Fetching vilages in under a district->countty->subcounty->parish.

Tests configurations and running:

  • PHP Unit
vendor/bin/phpunit

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@kusaasira kusaasira changed the title Ft refactor namespace Code Refactor Oct 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants