Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing Github Actions to ensure that pull requests are breaking features #7

Merged
merged 7 commits into from Oct 25, 2022

Conversation

RoadSigns
Copy link
Contributor

@RoadSigns RoadSigns commented Oct 25, 2022

Pull Request Description

This pull request is to allow users to control the dependencies themselves when using the package.
Leaving a composer.lock with outdated dependencies can introduce vulnerabilities into peoples applications but having a soft cap via composer.json allows Developers to be in control of their own packages.

Linting has been added to package to allow the support of PSR-12 (https://www.php-fig.org/psr/psr-12/) This is a coding standard that is used by Symfony, Laravel and also WordPress. This also sets a standard that other developers are use too, so it can increase the possibility of additional contributors.

Added the PHPUnit tests to the pipeline, this will ensure that no new pull requests will be breaking the unit tests, so all new versions of the package will have a working version.

Type (Feature, Fix, Config, etc)

  • Bug fix 🐞
  • New feature ✨
  • Breaking change 🔩
  • This change requires a documentation update 📙
  • Improvement 🌠
  • Refactor 🔄
  • Add Test Specs 🚦

Tests configurations and running:

  • PHP Unit
./vendor/bin/phpunit
  • Easy Coding Standard Test
./vendor/bin/ecs check src
./vendor/bin/ecs check src --fix

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@RoadSigns RoadSigns closed this Oct 25, 2022
@kusaasira
Copy link
Owner

@RoadSigns any reason why you closed this?

@RoadSigns
Copy link
Contributor Author

RoadSigns commented Oct 25, 2022

@kusaasira

I ended up seeing you was using another test runner in the end and was going to remove the Github actions but I'm happy to reopen it.

I was going to get this going before taking a look at one of the issues left

@RoadSigns RoadSigns reopened this Oct 25, 2022
Copy link
Owner

@kusaasira kusaasira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the refactor @RoadSigns. Introduction of coding standards. The test runner, the linting all look good to me.

composer.json Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@kusaasira kusaasira merged commit 0c99e96 into kusaasira:main Oct 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants