New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor codebase #8
Comments
@kusaasira Are you able to provide a link to the Appblocks Standards and Guidelines to ensure that they are being following correctly by anyone that picks these up? |
@RoadSigns since you added linting support for PSR-12. I'm suggesting we switch to following the PSR-12 coding standards and guidelines. Wouldn't that suffice? |
@kusaasira |
@kusaasira By the way, there is also a script now in the package called |
@RoadSigns the Concerning PHP Stan, If you are familiar, I would be grateful if you take lead here as am not that conversant though curious here. |
@kusaasira |
@RoadSigns yes, opening a PR sounds good. Yes, setting it up via Github Actions. |
@kusaasira So turns out we were unable to achieve PHPStan above level 1. So I've taken on the refactoring on the package so we are able to support searches across all scenarios.
This will give us all of the Villages inside of Bukomansimbi. From this refactor we are able to follow PSR-12 and also support up to PHPStan Level 9. |
@RoadSigns you did some good work over there in this PR #10. The previous codebase was locked into only json encoded data. Kudos! |
Refactor codebase to follow DRY / SOLID and reduce coupling.
Follow PSR-12 coding standards and guidelines.
The text was updated successfully, but these errors were encountered: