Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to add Child Element to a Window Element - npm run start throwing error. #162

Closed
joshi-ankur opened this issue Jun 23, 2018 · 11 comments
Labels

Comments

@joshi-ankur
Copy link

joshi-ankur commented Jun 23, 2018

@parro-it , @mischnic , @kusti8

So i just started working on building a proton-native desktop app on Windows 10 Pro edition.

I started off with the official documentation and my boiler plate code was ready.

npm run start was working fine and i was able to see . Below is the attached image.
my-desktop-app-boiler-plate-working

Now when i add a Box Component inside my Window component and try running the npm run start command, it fails :( . Have attached the image below for the same.

my-desktop-app-boiler-plate-not-working

Kindly help, i really need this to get working, am i doing something wrong?

@mischnic
Copy link
Contributor

mischnic commented Jun 23, 2018

The Button needs to have the onClick prop (not onClicked).

@kusti8 There should be a better error message.

@joshi-ankur
Copy link
Author

joshi-ankur commented Jun 23, 2018

@mischnic thanks for that change, i updated it. But then it is not solving my problem, i am still getting the same error mentioned above.

Kindly advice. Attached below is the image after updating the prop u mentioned.

my-desktop-app-boiler-plate-not-working-updated-prop

@mischnic
Copy link
Contributor

But then it is not solving my problem, i am still getting the same error mentioned above.

It's a different error (the line before the colored lines):

Window and Group only take one child!

Not sure why though.

@joshi-ankur
Copy link
Author

@mischnic @kusti8 @parro-it Can u please help me with a workaround to solve my problem? I need to get this desktop app up and running for my client.

@joshi-ankur
Copy link
Author

@mischnic yes it is a different error.

Window and Group only take one child

@JVictorV
Copy link

@joshi-ankur try to delete the "{ }" at the line 7

@parro-it
Copy link
Contributor

@joshi-ankur could you post the source code as text?

@kusti8 kusti8 added the bug label Jul 8, 2018
@maciek134
Copy link
Contributor

@joshi-ankur If you still need help with that, a good practice is to provide the source code for a minimal app that would reproduce this bug, nobody will retype everything from the images (in which the code is cropped btw so we can't even see some of it).

@Oxymoron290
Copy link

I was getting the error Window and Group only take one child! because I had a comment inside the Window tag...

Removing the comment inside of the window tag resolved my problem

@Oxymoron290
Copy link

plotter

@kusti8
Copy link
Owner

kusti8 commented Jan 19, 2020

Proton Native V2 is now released! If the issue still occurs in the new update, please open a new issue.

@kusti8 kusti8 closed this as completed Jan 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants